lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ishan Chattopadhyaya (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (LUCENE-6917) Deprecate and rename NumericField/RangeQuery to LegacyNumeric
Date Mon, 14 Dec 2015 08:22:46 GMT

    [ https://issues.apache.org/jira/browse/LUCENE-6917?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15055613#comment-15055613
] 

Ishan Chattopadhyaya commented on LUCENE-6917:
----------------------------------------------

I was trying to run a single test case for Solr,
{{ant test -Dtestcase=SolrExampleXMLTest}}

I see some javadocs failures related to this commit:
{code}
compile-core:
    [javac] Compiling 80 source files to /home/ishan/code/lucene-solr-svn/lucene/build/core/classes/java
    [javac] /home/ishan/code/lucene-solr-svn/lucene/core/src/java/org/apache/lucene/document/DateTools.java:109:
error: invalid use of @throws
    [javac]    * @throws ParseException if <code>dateString</code> is not in the

    [javac]      ^
    [javac] /home/ishan/code/lucene-solr-svn/lucene/core/src/java/org/apache/lucene/document/DateTools.java:123:
error: invalid use of @throws
    [javac]    * @throws ParseException if <code>dateString</code> is not in the

    [javac]      ^
    [javac] /home/ishan/code/lucene-solr-svn/lucene/core/src/java/org/apache/lucene/document/DimensionalBinaryField.java:97:
error: invalid use of @throws
    [javac]    *  @throws IllegalArgumentException if the field name or value is null.
    [javac]       ^
    [javac] /home/ishan/code/lucene-solr-svn/lucene/core/src/java/org/apache/lucene/document/DimensionalDoubleField.java:81:
error: invalid use of @throws
    [javac]    *  @throws IllegalArgumentException if the field name or value is null.
    [javac]       ^
    [javac] /home/ishan/code/lucene-solr-svn/lucene/core/src/java/org/apache/lucene/document/DimensionalFloatField.java:81:
error: invalid use of @throws
    [javac]    *  @throws IllegalArgumentException if the field name or value is null.
    [javac]       ^
    [javac] /home/ishan/code/lucene-solr-svn/lucene/core/src/java/org/apache/lucene/document/DimensionalIntField.java:81:
error: invalid use of @throws
    [javac]    *  @throws IllegalArgumentException if the field name or value is null.
    [javac]       ^
    [javac] /home/ishan/code/lucene-solr-svn/lucene/core/src/java/org/apache/lucene/document/DimensionalLongField.java:81:
error: invalid use of @throws
    [javac]    *  @throws IllegalArgumentException if the field name or value is null.
    [javac]       ^
    [javac] /home/ishan/code/lucene-solr-svn/lucene/core/src/java/org/apache/lucene/document/Field.java:87:
error: invalid use of @throws
    [javac]    * @throws IllegalArgumentException if either the name or type
    [javac]      ^
    [javac] /home/ishan/code/lucene-solr-svn/lucene/core/src/java/org/apache/lucene/document/Field.java:106:
error: invalid use of @throws
    [javac]    * @throws IllegalArgumentException if either the name or type
    [javac]      ^
    [javac] /home/ishan/code/lucene-solr-svn/lucene/core/src/java/org/apache/lucene/document/Field.java:109:
error: invalid use of @throws
    [javac]    * @throws NullPointerException if the reader is null
    [javac]      ^
    [javac] /home/ishan/code/lucene-solr-svn/lucene/core/src/java/org/apache/lucene/document/Field.java:138:
error: invalid use of @throws
    [javac]    * @throws IllegalArgumentException if either the name or type
    [javac]      ^
    [javac] /home/ishan/code/lucene-solr-svn/lucene/core/src/java/org/apache/lucene/document/Field.java:141:
error: invalid use of @throws
    [javac]    * @throws NullPointerException if the tokenStream is null
    [javac]      ^
    [javac] /home/ishan/code/lucene-solr-svn/lucene/core/src/java/org/apache/lucene/document/Field.java:171:
error: invalid use of @throws
    [javac]    * @throws IllegalArgumentException if the field name is null,
    [javac]      ^
    [javac] /home/ishan/code/lucene-solr-svn/lucene/core/src/java/org/apache/lucene/document/Field.java:173:
error: invalid use of @throws
    [javac]    * @throws NullPointerException if the type is null
    [javac]      ^
    [javac] /home/ishan/code/lucene-solr-svn/lucene/core/src/java/org/apache/lucene/document/Field.java:189:
error: invalid use of @throws
    [javac]    * @throws IllegalArgumentException if the field name is null,
    [javac]      ^
    [javac] /home/ishan/code/lucene-solr-svn/lucene/core/src/java/org/apache/lucene/document/Field.java:191:
error: invalid use of @throws
    [javac]    * @throws NullPointerException if the type is null
    [javac]      ^
    [javac] /home/ishan/code/lucene-solr-svn/lucene/core/src/java/org/apache/lucene/document/Field.java:205:
error: invalid use of @throws
    [javac]    * @throws IllegalArgumentException if the field name is null,
    [javac]      ^
    [javac] /home/ishan/code/lucene-solr-svn/lucene/core/src/java/org/apache/lucene/document/Field.java:207:
error: invalid use of @throws
    [javac]    * @throws NullPointerException if the type is null
    [javac]      ^
    [javac] /home/ishan/code/lucene-solr-svn/lucene/core/src/java/org/apache/lucene/document/Field.java:228:
error: invalid use of @throws
    [javac]    * @throws IllegalArgumentException if either the name or value
    [javac]      ^
    [javac] /home/ishan/code/lucene-solr-svn/lucene/core/src/java/org/apache/lucene/document/Field.java:231:
error: invalid use of @throws
    [javac]    * @throws NullPointerException if the type is null
    [javac]      ^
    [javac] /home/ishan/code/lucene-solr-svn/lucene/core/src/java/org/apache/lucene/document/Field.java:445:
error: invalid use of @throws
    [javac]    * @throws IllegalArgumentException if this field is not indexed, 
    [javac]      ^
    [javac] /home/ishan/code/lucene-solr-svn/lucene/core/src/java/org/apache/lucene/document/FieldType.java:119:
error: invalid use of @throws
    [javac]    * @throws IllegalStateException if this FieldType is frozen against
    [javac]      ^
    [javac] /home/ishan/code/lucene-solr-svn/lucene/core/src/java/org/apache/lucene/document/FieldType.java:142:
error: invalid use of @throws
    [javac]    * @throws IllegalStateException if this FieldType is frozen against
    [javac]      ^
    [javac] /home/ishan/code/lucene-solr-svn/lucene/core/src/java/org/apache/lucene/document/FieldType.java:166:
error: invalid use of @throws
    [javac]    * @throws IllegalStateException if this FieldType is frozen against
    [javac]      ^
    [javac] /home/ishan/code/lucene-solr-svn/lucene/core/src/java/org/apache/lucene/document/FieldType.java:190:
error: invalid use of @throws
    [javac]    * @throws IllegalStateException if this FieldType is frozen against
    [javac]      ^
    [javac] /home/ishan/code/lucene-solr-svn/lucene/core/src/java/org/apache/lucene/document/FieldType.java:214:
error: invalid use of @throws
    [javac]    * @throws IllegalStateException if this FieldType is frozen against
    [javac]      ^
    [javac] /home/ishan/code/lucene-solr-svn/lucene/core/src/java/org/apache/lucene/document/FieldType.java:238:
error: invalid use of @throws
    [javac]    * @throws IllegalStateException if this FieldType is frozen against
    [javac]      ^
    [javac] /home/ishan/code/lucene-solr-svn/lucene/core/src/java/org/apache/lucene/document/FieldType.java:261:
error: invalid use of @throws
    [javac]    * @throws IllegalStateException if this FieldType is frozen against
    [javac]      ^
    [javac] /home/ishan/code/lucene-solr-svn/lucene/core/src/java/org/apache/lucene/document/FieldType.java:284:
error: invalid use of @throws
    [javac]    * @throws IllegalStateException if this FieldType is frozen against
    [javac]      ^
    [javac] /home/ishan/code/lucene-solr-svn/lucene/core/src/java/org/apache/lucene/document/FieldType.java:299:
error: invalid use of @throws
    [javac]    * @throws IllegalStateException if this FieldType is frozen against
    [javac]      ^
    [javac] /home/ishan/code/lucene-solr-svn/lucene/core/src/java/org/apache/lucene/document/FieldType.java:323:
error: invalid use of @throws
    [javac]    * @throws IllegalArgumentException if precisionStep is less than 1. 
    [javac]      ^
    [javac] /home/ishan/code/lucene-solr-svn/lucene/core/src/java/org/apache/lucene/document/FieldType.java:324:
error: invalid use of @throws
    [javac]    * @throws IllegalStateException if this FieldType is frozen against
    [javac]      ^
    [javac] /home/ishan/code/lucene-solr-svn/lucene/core/src/java/org/apache/lucene/document/FieldType.java:455:
error: invalid use of @throws
    [javac]    * @throws IllegalStateException if this FieldType is frozen against
    [javac]      ^
    [javac] /home/ishan/code/lucene-solr-svn/lucene/core/src/java/org/apache/lucene/document/LegacyDoubleField.java:149:
error: invalid use of @throws
    [javac]    *  @throws IllegalArgumentException if the field name is null. 
    [javac]       ^
    [javac] /home/ishan/code/lucene-solr-svn/lucene/core/src/java/org/apache/lucene/document/LegacyDoubleField.java:162:
error: invalid use of @throws
    [javac]    *  @throws IllegalArgumentException if the field name or type is null, or
    [javac]       ^
    [javac] /home/ishan/code/lucene-solr-svn/lucene/core/src/java/org/apache/lucene/document/LegacyFloatField.java:151:
error: invalid use of @throws
    [javac]    *  @throws IllegalArgumentException if the field name is null.
    [javac]       ^
    [javac] /home/ishan/code/lucene-solr-svn/lucene/core/src/java/org/apache/lucene/document/LegacyFloatField.java:164:
error: invalid use of @throws
    [javac]    *  @throws IllegalArgumentException if the field name or type is null, or
    [javac]       ^
    [javac] /home/ishan/code/lucene-solr-svn/lucene/core/src/java/org/apache/lucene/document/LegacyIntField.java:151:
error: invalid use of @throws
    [javac]    *  @throws IllegalArgumentException if the field name is null.
    [javac]       ^
    [javac] /home/ishan/code/lucene-solr-svn/lucene/core/src/java/org/apache/lucene/document/LegacyIntField.java:164:
error: invalid use of @throws
    [javac]    *  @throws IllegalArgumentException if the field name or type is null, or
    [javac]       ^
    [javac] /home/ishan/code/lucene-solr-svn/lucene/core/src/java/org/apache/lucene/document/LegacyLongField.java:159:
error: invalid use of @throws
    [javac]    *  @throws IllegalArgumentException if the field name is null.
    [javac]       ^
    [javac] /home/ishan/code/lucene-solr-svn/lucene/core/src/java/org/apache/lucene/document/LegacyLongField.java:172:
error: invalid use of @throws
    [javac]    *  @throws IllegalArgumentException if the field name or type is null, or
    [javac]       ^
    [javac] /home/ishan/code/lucene-solr-svn/lucene/core/src/java/org/apache/lucene/document/SortedNumericDocValuesField.java:60:
error: invalid use of @throws
    [javac]    * @throws IllegalArgumentException if the field name is null
    [javac]      ^
    [javac] /home/ishan/code/lucene-solr-svn/lucene/core/src/java/org/apache/lucene/index/FieldInfos.java:184:
error: invalid use of @throws
    [javac]    * @throws IllegalArgumentException if fieldNumber is negative
    [javac]      ^
    [javac] /home/ishan/code/lucene-solr-svn/lucene/core/src/java/org/apache/lucene/search/CachingCollector.java:377:
error: invalid use of @throws
    [javac]    * @throws IllegalStateException
    [javac]      ^
    [javac] /home/ishan/code/lucene-solr-svn/lucene/core/src/java/org/apache/lucene/search/CachingCollector.java:380:
error: invalid use of @throws
    [javac]    * @throws IllegalArgumentException
    [javac]      ^
    [javac] /home/ishan/code/lucene-solr-svn/lucene/core/src/java/org/apache/lucene/search/Weight.java:85:
error: invalid use of @throws
    [javac]    * @throws IOException if an {@link IOException} occurs
    [javac]      ^
    [javac] /home/ishan/code/lucene-solr-svn/lucene/core/src/java/org/apache/lucene/search/Weight.java:114:
error: invalid use of @throws
    [javac]    * @throws IOException if there is a low-level I/O error
    [javac]      ^
    [javac] /home/ishan/code/lucene-solr-svn/lucene/core/src/java/org/apache/lucene/search/Weight.java:131:
error: invalid use of @throws
    [javac]    * @throws IOException if there is a low-level I/O error
    [javac]      ^
    [javac] /home/ishan/code/lucene-solr-svn/lucene/core/src/java/org/apache/lucene/search/spans/SpanWeight.java:83:
error: invalid use of @throws
    [javac]    * @throws IOException on error
    [javac]      ^
    [javac] /home/ishan/code/lucene-solr-svn/lucene/core/src/java/org/apache/lucene/search/spans/SpanWeight.java:115:
error: invalid use of @throws
    [javac]    * @throws IOException on error
    [javac]      ^
    [javac] /home/ishan/code/lucene-solr-svn/lucene/core/src/java/org/apache/lucene/search/spans/SpanWeight.java:145:
error: invalid use of @throws
    [javac]    * @throws IOException on error
    [javac]      ^
    [javac] /home/ishan/code/lucene-solr-svn/lucene/core/src/java/org/apache/lucene/util/LegacyNumericUtils.java:194:
error: invalid use of @throws
    [javac]    * @throws NumberFormatException if the supplied {@link BytesRef} is
    [javac]      ^
    [javac] /home/ishan/code/lucene-solr-svn/lucene/core/src/java/org/apache/lucene/util/LegacyNumericUtils.java:206:
error: invalid use of @throws
    [javac]    * @throws NumberFormatException if the supplied {@link BytesRef} is
    [javac]      ^
    [javac] /home/ishan/code/lucene-solr-svn/lucene/core/src/java/org/apache/lucene/util/LegacyNumericUtils.java:220:
error: invalid use of @throws
    [javac]    * @throws NumberFormatException if the supplied {@link BytesRef} is
    [javac]      ^
    [javac] /home/ishan/code/lucene-solr-svn/lucene/core/src/java/org/apache/lucene/util/LegacyNumericUtils.java:244:
error: invalid use of @throws
    [javac]    * @throws NumberFormatException if the supplied {@link BytesRef} is
    [javac]      ^
    [javac] Note: Some input files use or override a deprecated API.
    [javac] Note: Recompile with -Xlint:deprecation for details.
    [javac] 55 errors

{code}

Any ideas, please? Apologies, I don't have much understanding of these doclint failures. Is
there something wrong with my setup?

> Deprecate and rename NumericField/RangeQuery to LegacyNumeric
> -------------------------------------------------------------
>
>                 Key: LUCENE-6917
>                 URL: https://issues.apache.org/jira/browse/LUCENE-6917
>             Project: Lucene - Core
>          Issue Type: Improvement
>            Reporter: Michael McCandless
>            Assignee: Michael McCandless
>             Fix For: 6.0
>
>         Attachments: LUCENE-6917-broken-javadocs.patch, LUCENE-6917.patch, LUCENE-6917.patch,
LUCENE-6917.patch
>
>
> DimensionalValues seems to be better across the board (indexing time, indexing size,
search-speed, search-time heap required) than NumericField, at least in my testing so far.
> I think for 6.0 we should move {{IntField}}, {{LongField}}, {{FloatField}}, {{DoubleField}}
and {{NumericRangeQuery}} to {{backward-codecs}}, and rename with {{Legacy}} prefix?



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message