lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alan Woodward (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (SOLR-8360) ExternalFileField.getValueSource uses req.datadir but this.schema
Date Mon, 07 Dec 2015 16:25:11 GMT

    [ https://issues.apache.org/jira/browse/SOLR-8360?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15045185#comment-15045185
] 

Alan Woodward commented on SOLR-8360:
-------------------------------------

The data directory should always be the same, so I think your second patch is the way to go.

> ExternalFileField.getValueSource uses req.datadir but this.schema
> -----------------------------------------------------------------
>
>                 Key: SOLR-8360
>                 URL: https://issues.apache.org/jira/browse/SOLR-8360
>             Project: Solr
>          Issue Type: Task
>            Reporter: Christine Poerschke
>            Assignee: Christine Poerschke
>         Attachments: SOLR-8360-option1.patch, SOLR-8360-option2.patch
>
>
> {{ExternalFileField.getValueSource(SchemaField field, QParser parser)}} has available:
> * datadir
> ** parser.getReq().getCore().getDataDir()
> ** this.schema.getResourceLoader().getDataDir()
> * schema
> ** parser.getReq().getSchema()
> ** this.schema
> {{ExternalFileField.getValueSource}} uses {{parser.getReq().getCore().getDataDir()}}
explicitly but implicitly {{this.schema}} - should it use {{parser.getReq().getSchema()}}
instead (Option 1 patch)? Or if in practice actually req.datadir and this.datadir are always
the same could we stop using the parser argument (Option 2 patch (1 line))?



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message