lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Uwe Schindler (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (LUCENE-6732) Improve validate-source-patterns in build.xml (e.g., detect invalid license headers!!)
Date Mon, 07 Dec 2015 21:18:11 GMT

    [ https://issues.apache.org/jira/browse/LUCENE-6732?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15045746#comment-15045746
] 

Uwe Schindler commented on LUCENE-6732:
---------------------------------------

If you want to fix underlying issue open bug in Java bugtracker and request that File streams
include file name in exception message.

The Groovy script is fine, so please leve it as is. Maybe add debug logging for investigation
as said before.

> Improve validate-source-patterns in build.xml (e.g., detect invalid license headers!!)
> --------------------------------------------------------------------------------------
>
>                 Key: LUCENE-6732
>                 URL: https://issues.apache.org/jira/browse/LUCENE-6732
>             Project: Lucene - Core
>          Issue Type: Improvement
>            Reporter: Uwe Schindler
>            Assignee: Uwe Schindler
>             Fix For: Trunk, 5.4
>
>         Attachments: LUCENE-6732-v2.patch, LUCENE-6732.patch, LUCENE-6732.patch
>
>
> Today I enabled warnings analysis on Policeman Jenkins. This scans the build log for
warnings by javac and reports them in statistics, together with source file dumps.
> When doing that I found out that someone added again a lot of "invalid" license headers
using {{/\*\*}} instead a simple comment. This causes javadocs warnings under some circumstances,
because {{/\*\*}} is start of javadocs and not a license comment.
> I then tried to fix the validate-source-patterns to detect this, but due to a bug in
ANT, the {{<containsregexp/>}} filter is applied per line (although it has multiline
matching capabilities!!!).
> So I rewrote our checker to run with groovy. This also has some good parts:
> - it tells you wwhat was broken, otherwise you just know there is an error, but not whats
wrong (tab, nocommit,...)
> - its much faster (multiple {{<containsregexp/>}} read file over and over, this
one reads file one time into a string and then applies all regular expressions).



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message