lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Mikhail Khludnev (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (LUCENE-6910) fix 3 interesting and 2 trivial issues found by "Coverity scan results of Lucene"
Date Wed, 25 Nov 2015 12:17:11 GMT

    [ https://issues.apache.org/jira/browse/LUCENE-6910?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15026684#comment-15026684
] 

Mikhail Khludnev commented on LUCENE-6910:
------------------------------------------

patch seems fine, but the last chunk scares me much. as far as I get, nobody use it, it should
be a getter like
{code}
  public CharSequence[] getMultiFields() {
    return getQueryConfigHandler().get(ConfigurationKeys.MULTI_FIELDS);
  }
{code}
formally it's non-compatible change, but it think it's worth to break it even in 5.4, as an
alternative let's fix it in trunk only.  

 

> fix 3 interesting and 2 trivial issues found by "Coverity scan results of Lucene"
> ---------------------------------------------------------------------------------
>
>                 Key: LUCENE-6910
>                 URL: https://issues.apache.org/jira/browse/LUCENE-6910
>             Project: Lucene - Core
>          Issue Type: Task
>            Reporter: Christine Poerschke
>            Assignee: Christine Poerschke
>         Attachments: LUCENE-6910.patch
>
>
> https://scan.coverity.com/projects/5620 mentioned on the dev mailing list (http://mail-archives.apache.org/mod_mbox/lucene-dev/201507.mbox/%3cCAFTwexg51-jm_6MDEoz1rEagN3xgkBeTOz5OU_f+mELbOO1POw@mail.gmail.com%3e)
in July 2015:
> * coverity CID 119973
> * coverity CID 120040
> * coverity CID 120081
> * coverity CID 120628
> * coverity CID 120698



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message