lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Erik Hatcher (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (SOLR-8333) fix public methods that take/return private/package-private arguments/results
Date Tue, 24 Nov 2015 00:49:10 GMT

    [ https://issues.apache.org/jira/browse/SOLR-8333?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15023493#comment-15023493
] 

Erik Hatcher commented on SOLR-8333:
------------------------------------

While these issues the documentation checker found are mostly valid, would the workaround
of moving EmptyEntityResolver to org.apache.solr.common package in solrj be desirable?

> fix public methods that take/return private/package-private arguments/results
> -----------------------------------------------------------------------------
>
>                 Key: SOLR-8333
>                 URL: https://issues.apache.org/jira/browse/SOLR-8333
>             Project: Solr
>          Issue Type: Bug
>            Reporter: Hoss Man
>         Attachments: SOLR-8333-ConcurrentLFUCache-protected.patch, SOLR-8333.patch
>
>
> background info: http://mail-archives.apache.org/mod_mbox/lucene-dev/201511.mbox/%3Calpine.DEB.2.11.1511231128450.24330@tray%3E
> A commit that added a package to solrj which already existed in solr-core caused the
javadoc link checker to uncover at least 4 instances of private or package-private classes
being neccessary to use public APIs.
> we should fix these instances and any other instances of APIs with similar problems that
we can find.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message