lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ishan Chattopadhyaya (JIRA)" <j...@apache.org>
Subject [jira] [Comment Edited] (SOLR-8215) SolrCloud can select a core not in active state for querying
Date Thu, 29 Oct 2015 20:44:27 GMT

    [ https://issues.apache.org/jira/browse/SOLR-8215?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14981223#comment-14981223
] 

Ishan Chattopadhyaya edited comment on SOLR-8215 at 10/29/15 8:43 PM:
----------------------------------------------------------------------

I'm just wondering if this would mean that if a replica gets marked as down (due to bugs /
by mistake), one wouldn't be able to issue core admin commands to bring it back up if this
patch (and please correct me if I misunderstand this) short circuits the requests at the HttpSolrCall
layer. One such command is under discussion / development in SOLR-7569 (last few comments),
which will let the replica change its last published state. I'm not suggesting right away
that we don't do this patch, but do you have any thoughts around it (and recovery of such
replicas, in general)? Fyi, [~markrmiller@gmail.com].


was (Author: ichattopadhyaya):
I'm just wondering if this would mean that if a replica gets marked as down (due to bugs /
by mistake), one wouldn't be able to issue core admin commands to bring it back up if this
patch (and please correct me if I misunderstand this) short circuits the requests at the HttpSolrCall
layer. One such command is under discussion / development in SOLR-7569 (last few comments),
which will let the replica change its last published state. I'm not suggesting right away
that we don't do this, but do you have any thoughts around it (and recovery of such replicas,
in general)? Fyi, [~markrmiller@gmail.com].

> SolrCloud can select a core not in active state for querying
> ------------------------------------------------------------
>
>                 Key: SOLR-8215
>                 URL: https://issues.apache.org/jira/browse/SOLR-8215
>             Project: Solr
>          Issue Type: Bug
>            Reporter: Varun Thacker
>         Attachments: SOLR-8215.patch
>
>
> A query can be served by a core which is not in active state if the request hits the
node which hosts these non active cores.
> We explicitly check for only active cores to search against  in {{CloudSolrClient#sendRequest}}
Line 1043 on trunk.
> But we don't check this if someone uses the REST APIs 
> {{HttpSolrCall#getCoreByCollection}} should only pick cores which are active on line
794 on trunk. 
> We however check it on line 882/883 in HttpSolrCall, when we try to find cores on other
nodes when it's not present locally.
> So let's fix {{HttpSolrCall#getCoreByCollection}} to make the active check as well.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message