Mailing-List: contact dev-help@lucene.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@lucene.apache.org
Date: Wed, 9 Sep 2015 15:56:46 +0000 (UTC)
From: "ASF subversion and git services (JIRA)" <jira@apache.org>
To: dev@lucene.apache.org
Message-ID: <JIRA.12839167.1434729981000.291572.1441814206088@Atlassian.JIRA>
In-Reply-To: <JIRA.12839167.1434729981000@Atlassian.JIRA>
References: <JIRA.12839167.1434729981000@Atlassian.JIRA>
 <JIRA.12839167.1434729981497@arcas>
Subject: [jira] [Commented] (LUCENE-6590) Explore different ways to apply
 boosts
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/LUCENE-6590?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14737078#comment-14737078 ] 

ASF subversion and git services commented on LUCENE-6590:
---------------------------------------------------------

Commit 1702042 from [~jpountz] in branch 'dev/branches/branch_5x'
[ https://svn.apache.org/r1702042 ]

LUCENE-6590: Add back ToStringUtils.boost, which should not have been removed while merging.

> Explore different ways to apply boosts
> --------------------------------------
>
>                 Key: LUCENE-6590
>                 URL: https://issues.apache.org/jira/browse/LUCENE-6590
>             Project: Lucene - Core
>          Issue Type: Wish
>            Reporter: Adrien Grand
>            Priority: Minor
>             Fix For: 5.4
>
>         Attachments: LUCENE-6590.patch, LUCENE-6590.patch, LUCENE-6590.patch, LUCENE-6590.patch, LUCENE-6590.patch, LUCENE-6590.patch, LUCENE-6590.patch
>
>
> Follow-up from LUCENE-6570: the fact that all queries are mutable in order to allow for applying a boost raises issues since it makes queries bad cache keys since their hashcode can change anytime. We could just document that queries should never be modified after they have gone through IndexSearcher but it would be even better if the API made queries impossible to mutate at all.
> I think there are two main options:
>  - either replace "void setBoost(boost)" with something like "Query withBoost(boost)" which would return a clone that has a different boost
>  - or move boost handling outside of Query, for instance we could have a (immutable) query impl that would be dedicated to applying boosts, that queries that need to change boosts at rewrite time (such as BooleanQuery) would use as a wrapper.
> The latter idea is from Robert and I like it a lot given how often I either introduced or found a bug which was due to the boost parameter being ignored. Maybe there are other options, but I think this is worth exploring.


--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org