lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "songwanging (JIRA)" <j...@apache.org>
Subject [jira] [Created] (SOLR-8033) useless if branch
Date Thu, 10 Sep 2015 18:35:46 GMT
songwanging created SOLR-8033:
---------------------------------

             Summary: useless if branch
                 Key: SOLR-8033
                 URL: https://issues.apache.org/jira/browse/SOLR-8033
             Project: Solr
          Issue Type: Improvement
    Affects Versions: 5.1, 5.0
            Reporter: songwanging
            Priority: Minor


In method HdfsTransactionLog() of class HdfsTransactionLog (solr\core\src\java\org\apache\solr\update\HdfsTransactionLog.java)

The if branch presented in the following code snippet performs no actions, we should add more
code to handle this or directly delete this if branch.

HdfsTransactionLog(FileSystem fs, Path tlogFile, Collection<String> globalStrings, boolean
openExisting) {
  ...
    try {
      if (debug) {
        //log.debug("New TransactionLog file=" + tlogFile + ", exists=" + tlogFile.exists()
+ ", size=" + tlogFile.length() + ", openExisting=" + openExisting);
      }
...
}




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message