lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Michael McCandless (JIRA)" <>
Subject [jira] [Commented] (LUCENE-6702) [suggest] Make Context Query and Field extensible
Date Wed, 29 Jul 2015 20:27:07 GMT


Michael McCandless commented on LUCENE-6702:

Thanks [~areek], patch looks good ... can you give some example use cases
to motivate opening things up via subclassing?

I saw some minor things:

bq. +import java.util.*;

Could you fix your IDE to do keep each import separate?  Thanks.

I think toString is now not-so-friendly vs before, since we cutover to
IntsRef contexts key?  (IntsRef.toString vs CharSequence.toString).

> [suggest] Make Context Query and Field extensible
> -------------------------------------------------
>                 Key: LUCENE-6702
>                 URL:
>             Project: Lucene - Core
>          Issue Type: Improvement
>          Components: core/other
>    Affects Versions: Trunk
>            Reporter: Areek Zillur
>            Assignee: Areek Zillur
>             Fix For: Trunk
>         Attachments: LUCENE-6702.patch
> ContextSuggestField indexes context information along with 
> suggestions, which can be used to filter and/or boost suggestions using 
> ContextQuery.
> It would be useful to make ContextSuggestField extensible such that subclasses 
> can inject context values at index-time, without having to specify the 
> contexts in its ctor.
> ContextQuery can be made extensible by allowing sub-classes to override
> how context automaton is created from provided query contexts. 
> Currently, ContextQuery uses a context value of "*" to consider all context values, 
> It makes sense to have a dedicated {{addAllContexts()}} instead.  

This message was sent by Atlassian JIRA

To unsubscribe, e-mail:
For additional commands, e-mail:

View raw message