lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "david.w.smiley@gmail.com" <david.w.smi...@gmail.com>
Subject Re: ADDREPLICA and maxShardsPerNode and specifying a node
Date Sat, 11 Jul 2015 04:25:42 GMT
+1 to all Shai said.

On Thu, Jul 9, 2015 at 1:42 AM Shai Erera <serera@gmail.com> wrote:

> I think that if addreplica is called, we should assume the user
> understands what he's doing, and we can safely ignore maxShardsPerNode.
>
> +1 in renaming it. I don't think it's late to do anything. First, it
> probably is an advanced parameter to be specified, if not expert. Second,
> we can always deprecate it and add maxReplicasPerNode, support both and
> remove the former in 2 minor releases  or the next major one.
>
> IMO it's more important to have good API with sensible parameter names,
> than leave it as that because of back-compat concerns.
>
> Shai
> On Jul 9, 2015 8:33 AM, "Erick Erickson" <erickerickson@gmail.com> wrote:
>
>> I noticed today that if I create a collection with maxShardsPerNode, I
>> can freely exceed that number by specifying the "node" parameter on an
>> ADDREPLICA command.
>>
>> Is this intended behavior, or should I raise a JIRA? I can argue that
>> if a user is really going to specify a node, then we should do
>> whatever they say even if it exceeds maxShardsPerNode. If this is
>> intended though I'll want to explicitly call that out in ref guide.
>>
>> Erick
>>
>> P.S. I'd _really_ like to rename maxShardsPerNode to
>> maxReplicasPerNode, but it's too late for that.
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
>> For additional commands, e-mail: dev-help@lucene.apache.org
>>
>>  --
Lucene/Solr Search Committer, Consultant, Developer, Author, Speaker
LinkedIn: http://linkedin.com/in/davidwsmiley | Book:
http://www.solrenterprisesearchserver.com

Mime
View raw message