lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Uwe Schindler (JIRA)" <j...@apache.org>
Subject [jira] [Comment Edited] (LUCENE-6614) IOUtils.spins doesn't work for drives NVMe drives
Date Fri, 26 Jun 2015 11:48:04 GMT

    [ https://issues.apache.org/jira/browse/LUCENE-6614?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14602738#comment-14602738
] 

Uwe Schindler edited comment on LUCENE-6614 at 6/26/15 11:47 AM:
-----------------------------------------------------------------

Here is a quick patch, completely untested (no Linux available at the moment). The idea:

Instead of stripping off digits from the partition name and do exists() over and over, I think
the better solution is to take what's already there and not do brute force. This patch lists
the directory contents of /sys/block and for each file name it encounters, it checks if the
partition we got from mountpoint starts with the /sys/block device name. Of course there can
be overlap (loop1 vs loop10), so the largest match is taken.

Maybe Mike has some time to test, I will do this later in my VirtualBOX. I also added a test
for this type of device naming.


was (Author: thetaphi):
Here is a quick patch, completely untested (no Linux available at the moment). The idea:

Instead of stripping off digits from the partition name and do exists() over and over, I think
the better solution is to take what's already there and not do brute force. This patch lists
the directory contents of /sys/block and for each file name it encounters, it checks if the
partition we got from mountpoint starts with the /sys/block device name. Of course there can
be overlap, so the largest patch is taken.

Maybe Mike has some time to test, I will do this later in my VirtualBOX. I also added a test
for this type of device naming.

> IOUtils.spins doesn't work for drives NVMe drives
> -------------------------------------------------
>
>                 Key: LUCENE-6614
>                 URL: https://issues.apache.org/jira/browse/LUCENE-6614
>             Project: Lucene - Core
>          Issue Type: Bug
>            Reporter: Michael McCandless
>            Assignee: Uwe Schindler
>            Priority: Minor
>             Fix For: 5.3, Trunk
>
>         Attachments: LUCENE-6614.patch
>
>
> NVMe is the faster (than AHCI) protocol for newer SSDs that plug into the PCIE bus.
> I just built a new beast box with one of these drives, and the partition is named {{/dev/nvme0n1p1}}
while the device is {{/dev/nsme0n1}} by Linux - this also appears in /sys/block with rotational=0.
> I think [~steve_rowe] also has an NVME drive ...
> [~thetaphi] (who got the box working for me: thank you!!!) has ideas on how to fix it!



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message