lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Michael McCandless (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (LUCENE-6547) Add dateline crossing support to GeoPointInBBox and GeoPointDistance Queries
Date Thu, 18 Jun 2015 08:48:01 GMT

    [ https://issues.apache.org/jira/browse/LUCENE-6547?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14591497#comment-14591497
] 

Michael McCandless commented on LUCENE-6547:
--------------------------------------------

bq. That's only for PointDistance searching.

Ahh, OK; I wasn't sure when we should tolerate out-of-bounds lat/lon (and do the "wrapping"
ourselves) and when we shouldn't.

bq. No need to split into separate issues since this is all sandboxed anyway?

OK, thanks.  I can help here too (make testRandom more approachable)...

I took another look at the patch and I think besides these small test issues we should commit
it for 5.3; it's already plenty large enough: it adds a new query (GeoPointDistance), it fixes
queries to handle dateline wrapping, it refactors the GeoUtils APIs into three sources.

The last patch doesn't compile now because of the BQ Builder API changes...

> Add dateline crossing support to GeoPointInBBox and GeoPointDistance Queries
> ----------------------------------------------------------------------------
>
>                 Key: LUCENE-6547
>                 URL: https://issues.apache.org/jira/browse/LUCENE-6547
>             Project: Lucene - Core
>          Issue Type: Improvement
>          Components: core/search
>            Reporter: Nicholas Knize
>         Attachments: LUCENE-6547.patch, LUCENE-6547.patch, LUCENE-6547.patch, LUCENE-6547.patch,
LUCENE-6547.patch
>
>
> The current GeoPointInBBoxQuery only supports bounding boxes that are within the standard
-180:180 longitudinal bounds. While its perfectly fine to require users to split dateline
crossing bounding boxes in two, GeoPointDistanceQuery should support distance queries that
cross the dateline.  Since morton encoding doesn't support unwinding this issue will add dateline
crossing to GeoPointInBBoxQuery and GeoPointDistanceQuery classes.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message