lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Uwe Schindler (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (LUCENE-6530) Use Java 7 ProcessBuilder.inheritIO() instead of own ThreadPumper
Date Sun, 07 Jun 2015 10:44:00 GMT

    [ https://issues.apache.org/jira/browse/LUCENE-6530?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14576183#comment-14576183
] 

Uwe Schindler commented on LUCENE-6530:
---------------------------------------

This is a nice cleanup, but has one backside: The process output is directly piped to stderr/stdout,
so Junit4 cannot intercept it. So we should decide if this is a problem. The JRE crash indexwriter
now shows the output because the JUnit4 runner tells about "unexpected stderr/stdout output".

So we should disable if we want the simplier code without manual pumping threads or keep the
current code.

> Use Java 7 ProcessBuilder.inheritIO() instead of own ThreadPumper
> -----------------------------------------------------------------
>
>                 Key: LUCENE-6530
>                 URL: https://issues.apache.org/jira/browse/LUCENE-6530
>             Project: Lucene - Core
>          Issue Type: Improvement
>            Reporter: Uwe Schindler
>            Assignee: Uwe Schindler
>              Labels: Java7
>             Fix For: Trunk, 5.3
>
>         Attachments: LUCENE-6530.patch
>
>
> In some tests wie spawn separate processes (TestIndexWriterOnJRECrash and Solr's IPTables).
To capture stdin/stdout/stderr we spawn several threads that pump those to stdout/stderr.
> Since Java 7 there is ProcessBuilder.inheritIO() that does this for us without any additional
threads. We should use this instead. Fix is easy, just remove some stuff :-)
> I did the same already for my Codec classloader deadlock test, so this is just a followup
for the other tests.
> Patch is attached and can be committed to trunk and 5.x.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message