lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF subversion and git services (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (SOLR-7472) SortingResponseWriter does not log fl parameters that don't exist.
Date Fri, 15 May 2015 18:42:00 GMT

    [ https://issues.apache.org/jira/browse/SOLR-7472?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14545969#comment-14545969
] 

ASF subversion and git services commented on SOLR-7472:
-------------------------------------------------------

Commit 1679619 from [~joel.bernstein] in branch 'dev/branches/branch_5x'
[ https://svn.apache.org/r1679619 ]

SOLR-7472: SortingResponseWriter does not log fl parameters that don't exist.

> SortingResponseWriter does not log fl parameters that don't exist.
> ------------------------------------------------------------------
>
>                 Key: SOLR-7472
>                 URL: https://issues.apache.org/jira/browse/SOLR-7472
>             Project: Solr
>          Issue Type: Bug
>    Affects Versions: 4.9, 4.9.1, 4.10, 4.10.1, 4.10.2, 4.10.4, 5.0, 5.1
>            Reporter: Joel Bernstein
>            Assignee: Joel Bernstein
>             Fix For: 5.2
>
>         Attachments: SOLR-7472.patch
>
>
> The SortingResponseWriter, which is the response writer for the /export handler, does
not log the error that is thrown when an fl is specified that does not exist.
> The reason for this is that an unchecked SolrException is being thrown from the IndexSchema.
All other exceptions in SortingResponseWriter are wrapped in an IOException. 
> For reasons I'm not entirely sure of the ResponseUtils class doesn't log the stacktrace
for errors with codes between 500 and 100. It considers these to be normal error conditions.
So the unchecked SolrException was not being logged.
> The short term fix for this is to catch the exception from the IndexSchema and wrap it
in a IOException like the other exceptions from the SortingResponseWriter.
> Longer term I think it makes sense to review the ResponseUtil exception logging logic.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message