Return-Path: X-Original-To: apmail-lucene-dev-archive@www.apache.org Delivered-To: apmail-lucene-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 73DBB178C3 for ; Wed, 25 Mar 2015 19:18:19 +0000 (UTC) Received: (qmail 73677 invoked by uid 500); 25 Mar 2015 19:18:18 -0000 Delivered-To: apmail-lucene-dev-archive@lucene.apache.org Received: (qmail 73617 invoked by uid 500); 25 Mar 2015 19:18:18 -0000 Mailing-List: contact dev-help@lucene.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@lucene.apache.org Delivered-To: mailing list dev@lucene.apache.org Received: (qmail 73606 invoked by uid 99); 25 Mar 2015 19:18:18 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 25 Mar 2015 19:18:18 +0000 X-ASF-Spam-Status: No, hits=1.5 required=5.0 tests=HTML_MESSAGE,RCVD_IN_DNSWL_LOW,SPF_PASS X-Spam-Check-By: apache.org Received-SPF: pass (nike.apache.org: domain of serera@gmail.com designates 209.85.215.42 as permitted sender) Received: from [209.85.215.42] (HELO mail-la0-f42.google.com) (209.85.215.42) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 25 Mar 2015 19:17:52 +0000 Received: by lagg8 with SMTP id g8so28076884lag.1 for ; Wed, 25 Mar 2015 12:16:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :content-type; bh=L4g5vW/YDSDBYs5Mq2h+Urkj+7s8dEKXJVOqGyLZaJo=; b=T3j/CNSlWD3tYZvJ2IbWnJ5a7KEt34X02OQI1GP9Qyq8WZTaNrvBIGuJs7he31wF8E lPL2PsP09WQTkC4d4ROsi1y56tc0QJCISB4IA5TZmkOvawKOYSbJUs0Va62QyCrcv8ni bX7WCM0olAlKBzgK1bzUKq3wfRXHwVIFj6wL12lN86N2u3yE6SKsBmpl2YRdPEutsFit p7bG5dnRnkMFYWBoz8HgkwDvxsV2uB8W3rZJhzP/qMFVEd0/C3D3sUpZpg0QV0j1lbtu z8FG0iVwe3pBM0/HRzbW4AKMFKCLNy7Xmurfd2GujuPtZk8cjC2dcdm7f0iGVE3jAQXa 1CMw== MIME-Version: 1.0 X-Received: by 10.112.147.200 with SMTP id tm8mr9752087lbb.71.1427310980537; Wed, 25 Mar 2015 12:16:20 -0700 (PDT) Received: by 10.112.47.67 with HTTP; Wed, 25 Mar 2015 12:16:20 -0700 (PDT) Received: by 10.112.47.67 with HTTP; Wed, 25 Mar 2015 12:16:20 -0700 (PDT) In-Reply-To: References: <20150325164407.9140EAC01AB@hades.apache.org> Date: Wed, 25 Mar 2015 21:16:20 +0200 Message-ID: Subject: Re: svn commit: r1669153 - /lucene/dev/trunk/solr/solrj/src/java/org/apache/solr/common/cloud/ClusterState.java From: Shai Erera To: dev@lucene.apache.org Content-Type: multipart/alternative; boundary=047d7b3a8966faa4fe051221bb89 X-Virus-Checked: Checked by ClamAV on apache.org --047d7b3a8966faa4fe051221bb89 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Oh geez, I didn't believe adding a tostring will break tests =E2=98=BA. I'l= l commit a fix. Sorry! On Mar 25, 2015 8:09 PM, "Shalin Shekhar Mangar" wrote: > We need a null check here. The collection can be null if the CollectionRe= f > is lazy loaded. > > On Wed, Mar 25, 2015 at 11:08 AM, Shalin Shekhar Mangar < > shalinmangar@gmail.com> wrote: > >> This broke some of the tests. >> >> On Wed, Mar 25, 2015 at 9:44 AM, wrote: >> >>> Author: shaie >>> Date: Wed Mar 25 16:44:07 2015 >>> New Revision: 1669153 >>> >>> URL: http://svn.apache.org/r1669153 >>> Log: >>> add toString() to CollectionRef >>> >>> Modified: >>> >>> lucene/dev/trunk/solr/solrj/src/java/org/apache/solr/common/cloud/Clust= erState.java >>> >>> Modified: >>> lucene/dev/trunk/solr/solrj/src/java/org/apache/solr/common/cloud/Clust= erState.java >>> URL: >>> http://svn.apache.org/viewvc/lucene/dev/trunk/solr/solrj/src/java/org/a= pache/solr/common/cloud/ClusterState.java?rev=3D1669153&r1=3D1669152&r2=3D1= 669153&view=3Ddiff >>> >>> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D >>> --- >>> lucene/dev/trunk/solr/solrj/src/java/org/apache/solr/common/cloud/Clust= erState.java >>> (original) >>> +++ >>> lucene/dev/trunk/solr/solrj/src/java/org/apache/solr/common/cloud/Clust= erState.java >>> Wed Mar 25 16:44:07 2015 >>> @@ -391,6 +391,11 @@ public class ClusterState implements JSO >>> } >>> >>> public boolean isLazilyLoaded() { return false; } >>> + >>> + @Override >>> + public String toString() { >>> + return coll.toString(); >>> + } >>> >>> } >>> >>> >>> >>> >> >> >> -- >> Regards, >> Shalin Shekhar Mangar. >> > > > > -- > Regards, > Shalin Shekhar Mangar. > --047d7b3a8966faa4fe051221bb89 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable

Oh geez, I didn't believe adding a tostring will break t= ests =E2=98=BA. I'll commit a fix. Sorry!

On Mar 25, 2015 8:09 PM, "Shalin Shekhar Ma= ngar" <shalinmangar@gmail= .com> wrote:
=
We need a null check here. The collection can be null if t= he CollectionRef is lazy loaded.

On Wed, Mar 25, 2015 at 11:08 AM, Shalin Shekhar Manga= r <shalinmangar@gmail.com> wrote:
This broke some of the tests.

On Wed, Mar 25, = 2015 at 9:44 AM, <shaie@apache.org> wrote:
Author: shaie
Date: Wed Mar 25 16:44:07 2015
New Revision: 1669153

URL: http://sv= n.apache.org/r1669153
Log:
add toString() to CollectionRef

Modified:
=C2=A0 =C2=A0 lucene/dev/trunk/solr/solrj/src/java/org/apache/solr/common/c= loud/ClusterState.java

Modified: lucene/dev/trunk/solr/solrj/src/java/org/apache/solr/common/cloud= /ClusterState.java
URL: http://svn.a= pache.org/viewvc/lucene/dev/trunk/solr/solrj/src/java/org/apache/solr/commo= n/cloud/ClusterState.java?rev=3D1669153&r1=3D1669152&r2=3D1669153&a= mp;view=3Ddiff
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D
--- lucene/dev/trunk/solr/solrj/src/java/org/apache/solr/common/cloud/Clust= erState.java (original)
+++ lucene/dev/trunk/solr/solrj/src/java/org/apache/solr/common/cloud/Clust= erState.java Wed Mar 25 16:44:07 2015
@@ -391,6 +391,11 @@ public class ClusterState implements JSO
=C2=A0 =C2=A0 =C2=A0}

=C2=A0 =C2=A0 =C2=A0public boolean isLazilyLoaded() { return false; }
+
+=C2=A0 =C2=A0 @Override
+=C2=A0 =C2=A0 public String toString() {
+=C2=A0 =C2=A0 =C2=A0 return coll.toString();
+=C2=A0 =C2=A0 }

=C2=A0 =C2=A0}






<= font color=3D"#888888">--
Regards,
Shalin Shekhar Mangar.



--
Regards= ,
Shalin Shekhar Mangar.
--047d7b3a8966faa4fe051221bb89--