lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Robert Muir (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (LUCENE-6335) fail tests on threadlocal leaks
Date Wed, 04 Mar 2015 06:13:04 GMT

     [ https://issues.apache.org/jira/browse/LUCENE-6335?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Robert Muir updated LUCENE-6335:
--------------------------------
    Attachment: LUCENE-6335.patch

here is a REALLY hacky patch. I based it on tomcat's threadlocal leak detector, but with some
simpler/imperfect logic as a start, since e.g. we aren't wrapping tests in custom classloader
or any of that stuff.

I only fixed TestDemo and LineFileDocs so far and didnt look much more at failures.

> fail tests on threadlocal leaks
> -------------------------------
>
>                 Key: LUCENE-6335
>                 URL: https://issues.apache.org/jira/browse/LUCENE-6335
>             Project: Lucene - Core
>          Issue Type: Test
>            Reporter: Robert Muir
>         Attachments: LUCENE-6335.patch
>
>
> I know this requires us to do things like close our Analyzers in tests, but I think we
should do it. just experimenting i found other leaks, e.g. in LineFileDocs.
> {noformat}
>    [junit4] ERROR   0.00s J0 | TestForceMergeForever (suite) <<<
>    [junit4]    > Throwable #1: java.lang.IllegalStateException: ThreadLocal leaks
were found: 
>    [junit4]    > 1. thread=SUITE-TestForceMergeForever-seed#[AF7141C55A57350E]-worker
value=WeakReference<HashMap<?,Analyzer$TokenStreamComponents>>
>    [junit4]    > 2. thread=SUITE-TestForceMergeForever-seed#[AF7141C55A57350E]-worker
value=LineFileDocs$DocState
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message