lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Shai Erera <ser...@gmail.com>
Subject Re: svn commit: r1669153 - /lucene/dev/trunk/solr/solrj/src/java/org/apache/solr/common/cloud/ClusterState.java
Date Wed, 25 Mar 2015 19:16:20 GMT
Oh geez, I didn't believe adding a tostring will break tests ☺. I'll commit
a fix. Sorry!
On Mar 25, 2015 8:09 PM, "Shalin Shekhar Mangar" <shalinmangar@gmail.com>
wrote:

> We need a null check here. The collection can be null if the CollectionRef
> is lazy loaded.
>
> On Wed, Mar 25, 2015 at 11:08 AM, Shalin Shekhar Mangar <
> shalinmangar@gmail.com> wrote:
>
>> This broke some of the tests.
>>
>> On Wed, Mar 25, 2015 at 9:44 AM, <shaie@apache.org> wrote:
>>
>>> Author: shaie
>>> Date: Wed Mar 25 16:44:07 2015
>>> New Revision: 1669153
>>>
>>> URL: http://svn.apache.org/r1669153
>>> Log:
>>> add toString() to CollectionRef
>>>
>>> Modified:
>>>
>>> lucene/dev/trunk/solr/solrj/src/java/org/apache/solr/common/cloud/ClusterState.java
>>>
>>> Modified:
>>> lucene/dev/trunk/solr/solrj/src/java/org/apache/solr/common/cloud/ClusterState.java
>>> URL:
>>> http://svn.apache.org/viewvc/lucene/dev/trunk/solr/solrj/src/java/org/apache/solr/common/cloud/ClusterState.java?rev=1669153&r1=1669152&r2=1669153&view=diff
>>>
>>> ==============================================================================
>>> ---
>>> lucene/dev/trunk/solr/solrj/src/java/org/apache/solr/common/cloud/ClusterState.java
>>> (original)
>>> +++
>>> lucene/dev/trunk/solr/solrj/src/java/org/apache/solr/common/cloud/ClusterState.java
>>> Wed Mar 25 16:44:07 2015
>>> @@ -391,6 +391,11 @@ public class ClusterState implements JSO
>>>      }
>>>
>>>      public boolean isLazilyLoaded() { return false; }
>>> +
>>> +    @Override
>>> +    public String toString() {
>>> +      return coll.toString();
>>> +    }
>>>
>>>    }
>>>
>>>
>>>
>>>
>>
>>
>> --
>> Regards,
>> Shalin Shekhar Mangar.
>>
>
>
>
> --
> Regards,
> Shalin Shekhar Mangar.
>

Mime
View raw message