Return-Path: X-Original-To: apmail-lucene-dev-archive@www.apache.org Delivered-To: apmail-lucene-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 2B71410353 for ; Mon, 16 Feb 2015 21:11:13 +0000 (UTC) Received: (qmail 50965 invoked by uid 500); 16 Feb 2015 21:11:12 -0000 Delivered-To: apmail-lucene-dev-archive@lucene.apache.org Received: (qmail 50889 invoked by uid 500); 16 Feb 2015 21:11:12 -0000 Mailing-List: contact dev-help@lucene.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@lucene.apache.org Delivered-To: mailing list dev@lucene.apache.org Received: (qmail 50874 invoked by uid 99); 16 Feb 2015 21:11:12 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 16 Feb 2015 21:11:12 +0000 Date: Mon, 16 Feb 2015 21:11:12 +0000 (UTC) From: "Yonik Seeley (JIRA)" To: dev@lucene.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (SOLR-7110) Optimize JavaBinCodec to minimize string Object creation MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/SOLR-7110?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14323296#comment-14323296 ] Yonik Seeley commented on SOLR-7110: ------------------------------------ This should really only affect how fast the young gen fills up, which should not have an effect on full GCs. bq. So, this is not really an optimization on CPU, it is a memory optimization. The question at hand is if the memory optimization is worth the CPU overhead here. What's the long term decoding throughput before and after the patch? > Optimize JavaBinCodec to minimize string Object creation > -------------------------------------------------------- > > Key: SOLR-7110 > URL: https://issues.apache.org/jira/browse/SOLR-7110 > Project: Solr > Issue Type: Improvement > Reporter: Noble Paul > Assignee: Noble Paul > Priority: Minor > Attachments: SOLR-7110.patch, SOLR-7110.patch > > > In JavabinCodec we already optimize on strings creation , if they are repeated in the same payload. if we use a cache it is possible to avoid string creation across objects as well. -- This message was sent by Atlassian JIRA (v6.3.4#6332) --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org For additional commands, e-mail: dev-help@lucene.apache.org