lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ishan Chattopadhyaya (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (SOLR-7168) TestSolrConfigHandler Test failure :Could not remove the following files
Date Fri, 27 Feb 2015 12:36:05 GMT

     [ https://issues.apache.org/jira/browse/SOLR-7168?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Ishan Chattopadhyaya updated SOLR-7168:
---------------------------------------
    Attachment: SOLR-7168.patch

Even after this fix, this test was still failing on Windows.
http://jenkins.thetaphi.de/job/Lucene-Solr-trunk-Windows/4508/testReport/junit/junit.framework/TestSuite/org_apache_solr_core_TestSolrConfigHandler/

Attached a patch to fix this failure. Putting the OutputStream into a try with resources (instead
of org.apache.commons.io.IOUtils.closeQuietly()) and replacing FileUtils.sync() to oal.util.IOUtils.fsync()
fixes the failure.

Just a thought, since the FileUtils.sync() mentions it has been copied from FSDirectory.fsync()
and that FSDirectory.fsync() itself is now just a wrapper to oal.util.IOUtils.fsync(), shouldn't
we just remove FileUtils.sync() altogether? It seems to be referred to from SnapPuller and
ManagedIndexSchema.

> TestSolrConfigHandler Test failure :Could not remove the following files 
> -------------------------------------------------------------------------
>
>                 Key: SOLR-7168
>                 URL: https://issues.apache.org/jira/browse/SOLR-7168
>             Project: Solr
>          Issue Type: Bug
>         Environment: http://jenkins.thetaphi.de/job/Lucene-Solr-trunk-Windows/4508/
> {noformat}
> Stack Trace:
> java.io.IOException: Could not remove the following files (in the order of attempts):
>    C:\Users\JenkinsSlave\workspace\Lucene-Solr-trunk-Windows\solr\build\solr-core\test\J0\temp\solr.core.TestSolrConfigHandler
7373A4FF3B396841-001\tempDir-010\collection1\conf\params.json:
> {noformat}
>            Reporter: Noble Paul
>            Assignee: Noble Paul
>            Priority: Minor
>             Fix For: Trunk, 5.1
>
>         Attachments: SOLR-7168.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message