lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Robert Muir (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (LUCENE-6264) Add SuppressFileSystems annotation.
Date Thu, 19 Feb 2015 21:02:13 GMT

    [ https://issues.apache.org/jira/browse/LUCENE-6264?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14328120#comment-14328120
] 

Robert Muir commented on LUCENE-6264:
-------------------------------------

Well and beware a lot of this filesystem testing stuff is... not yet in the best shape. For
example our mock Windows does not actually mock windows very well. It could be greatly improved
to better simulate some of the things that can happen there and be consistent. Its one reason
why we don't enable mock windows on windows itself.

So I think the annotation is generally useful because of that too.

> Add SuppressFileSystems annotation.
> -----------------------------------
>
>                 Key: LUCENE-6264
>                 URL: https://issues.apache.org/jira/browse/LUCENE-6264
>             Project: Lucene - Core
>          Issue Type: Test
>            Reporter: Robert Muir
>         Attachments: LUCENE-6264.patch
>
>
> kinda like SuppressCodecs, to make it easier to disable cornercases that don't play with
anything we are doing at this level.
> the one example we have today is LUCENE-5574, the bug just doesnt happen on windows because
you can't delete open files there, so the test won't work. Today it uses a hacky method to
disable mock windowsFS.
> But being able to easily turn these off for rare exotic cases, will make it easier to
improve/add them for the general case.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message