lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Adrien Grand (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (LUCENE-6229) Remove Scorer.getChildren?
Date Fri, 20 Feb 2015 16:12:12 GMT

    [ https://issues.apache.org/jira/browse/LUCENE-6229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14329108#comment-14329108
] 

Adrien Grand commented on LUCENE-6229:
--------------------------------------

bq. just let getChildren() be completely transparent about where scorers are positioned

I agree this is the only reasonable definition of getChildren that we could have if we want
to keep it, otherwise it puts too many constraints on the scorers.

> Remove Scorer.getChildren?
> --------------------------
>
>                 Key: LUCENE-6229
>                 URL: https://issues.apache.org/jira/browse/LUCENE-6229
>             Project: Lucene - Core
>          Issue Type: Improvement
>            Reporter: Adrien Grand
>            Priority: Minor
>
> This API is used in a single place in our code base: ToParentBlockJoinCollector. In addition,
the usage is a bit buggy given that using this API from a collector only works if setScorer
is called with an actual Scorer (and not eg. FakeScorer or BooleanScorer like you would get
in disjunctions) so it needs a custom IndexSearcher that does not use the BulkScorer API.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message