Return-Path: 
 <dev-return-192378-apmail-lucene-dev-archive=lucene.apache.org@lucene.apache.org>
X-Original-To: apmail-lucene-dev-archive@www.apache.org
Delivered-To: apmail-lucene-dev-archive@www.apache.org
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by minotaur.apache.org (Postfix) with SMTP id 2DFEC17DD1
	for <apmail-lucene-dev-archive@www.apache.org>;
 Thu, 15 Jan 2015 23:37:34 +0000 (UTC)
Received: (qmail 94241 invoked by uid 500); 15 Jan 2015 23:37:35 -0000
Delivered-To: apmail-lucene-dev-archive@lucene.apache.org
Received: (qmail 94171 invoked by uid 500); 15 Jan 2015 23:37:35 -0000
Mailing-List: contact dev-help@lucene.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:dev-help@lucene.apache.org>
List-Unsubscribe: <mailto:dev-unsubscribe@lucene.apache.org>
List-Post: <mailto:dev@lucene.apache.org>
List-Id: <dev.lucene.apache.org>
Reply-To: dev@lucene.apache.org
Delivered-To: mailing list dev@lucene.apache.org
Received: (qmail 94158 invoked by uid 99); 15 Jan 2015 23:37:35 -0000
Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28)
    by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 15 Jan 2015 23:37:35 +0000
Date: Thu, 15 Jan 2015 23:37:35 +0000 (UTC)
From: "Boon Low (JIRA)" <jira@apache.org>
To: dev@lucene.apache.org
Message-ID: <JIRA.12750097.1414079360000.97356.1421365055031@Atlassian.JIRA>
In-Reply-To: <JIRA.12750097.1414079360000@Atlassian.JIRA>
References: <JIRA.12750097.1414079360000@Atlassian.JIRA>
 <JIRA.12750097.1414079360135@arcas>
Subject: [jira] [Comment Edited] (SOLR-6648) AnalyzingInfixLookupFactory
 always highlights suggestions
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394


    [ https://issues.apache.org/jira/browse/SOLR-6648?page=3Dcom.atlassian.=
jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=3D14261=
237#comment-14261237 ]=20

Boon Low edited comment on SOLR-6648 at 1/15/15 11:37 PM:
----------------------------------------------------------

I have created a patche for this, in Lucene and Solr, so that highlighting =
and the Boolean matching clause can be configured in solrconfig.xml, for *B=
lendedInfixSuggester* and *AnalyzingInfixSuggester*:

{code:xml}
   <lst name=3D"suggester">
        <str name=3D"name">..</str>
        <str name=3D"lookupImpl">BlendedInfixLookupFactory</str>
        <str name=3D"dictionaryImpl">DocumentDictionaryFactory</str>
         ...
        <str name=3D"allTermsRequired">false</str>
        <str name=3D"highlight">true</str>
     </lst>
{code}

If not configured, both 'highlighting' and 'allTermsRequired' default to *t=
rue.


was (Author: boonious):
I have created a patche for this, in Lucene and Solr, so that highlighting =
and the Boolean matching clause can be configured in solrconfig.xml, for *B=
lendedInfixSuggester* and *AnalyzingInfixSuggester*:

{code:xml}
   <lst name=3D"suggester">
        <str name=3D"name">..</str>
        <str name=3D"lookupImpl">BlendedInfixLookupFactory</str>
        <str name=3D"dictionaryImpl">DocumentDictionaryFactory</str>
         ...
        <str name=3D"allTermsRequired">false</str>
        <str name=3D"highlighting">true</str>
     </lst>
{code}

If not configured, both 'highlighting' and 'allTermsRequired' default to *t=
rue.

> AnalyzingInfixLookupFactory always highlights suggestions
> ---------------------------------------------------------
>
>                 Key: SOLR-6648
>                 URL: https://issues.apache.org/jira/browse/SOLR-6648
>             Project: Solr
>          Issue Type: Sub-task
>    Affects Versions: 4.9, 4.9.1, 4.10, 4.10.1
>            Reporter: Varun Thacker
>            Assignee: Tom=C3=A1s Fern=C3=A1ndez L=C3=B6bbe
>              Labels: suggester
>             Fix For: 5.0, Trunk
>
>         Attachments: SOLR-6648-v4.10.3.patch, SOLR-6648.patch
>
>
> When using AnalyzingInfixLookupFactory suggestions always return with the=
 match term as highlighted and 'allTermsRequired' is always set to true.
> We should be able to configure those.
> Steps to reproduce -=20
> schema additions
> {code}
> <searchComponent name=3D"suggest" class=3D"solr.SuggestComponent">
>     <lst name=3D"suggester">
>       <str name=3D"name">mySuggester</str>
>       <str name=3D"lookupImpl">AnalyzingInfixLookupFactory</str>
>       <str name=3D"dictionaryImpl">DocumentDictionaryFactory</str>=20
>       <str name=3D"field">suggestField</str>
>       <str name=3D"weightField">weight</str>
>       <str name=3D"suggestAnalyzerFieldType">textSuggest</str>
>     </lst>
>   </searchComponent>
>   <requestHandler name=3D"/suggest" class=3D"solr.SearchHandler" startup=
=3D"lazy">
>     <lst name=3D"defaults">
>       <str name=3D"suggest">true</str>
>       <str name=3D"suggest.count">10</str>
>     </lst>
>     <arr name=3D"components">
>       <str>suggest</str>
>     </arr>
>   </requestHandler>
> {code}
> solrconfig changes -
> {code}
> <fieldType class=3D"solr.TextField" name=3D"textSuggest" positionIncremen=
tGap=3D"100">
>    <analyzer>
>       <tokenizer class=3D"solr.StandardTokenizerFactory"/>
>       <filter class=3D"solr.StandardFilterFactory"/>
>       <filter class=3D"solr.LowerCaseFilterFactory"/>
>    </analyzer>
>   </fieldType>
>    <field name=3D"suggestField" type=3D"textSuggest" indexed=3D"true" sto=
red=3D"true"/>
> {code}
> Add 3 documents -=20
> {code}
> curl http://localhost:8983/solr/update/json?commit=3Dtrue -H 'Content-typ=
e:application/json' -d '
> [ {"id" : "1", "suggestField" : "bass fishing"}, {"id" : "2", "suggestFie=
ld" : "sea bass"}, {"id" : "3", "suggestField" : "sea bass fishing"} ]
> '
> {code}
> Query -
> {code}
> http://localhost:8983/solr/collection1/suggest?suggest.build=3Dtrue&sugge=
st.dictionary=3DmySuggester&q=3Dbass&wt=3Djson&indent=3Don
> {code}
> Response=20
> {code}
> {
>   "responseHeader":{
>     "status":0,
>     "QTime":25},
>   "command":"build",
>   "suggest":{"mySuggester":{
>       "bass":{
>         "numFound":3,
>         "suggestions":[{
>             "term":"<b>bass</b> fishing",
>             "weight":0,
>             "payload":""},
>           {
>             "term":"sea <b>bass</b>",
>             "weight":0,
>             "payload":""},
>           {
>             "term":"sea <b>bass</b> fishing",
>             "weight":0,
>             "payload":""}]}}}}
> {code}
> The problem is in SolrSuggester Line 200 where we say lookup.lookup()
> This constructor does not take allTermsRequired and doHighlight since it'=
s only tuneable to AnalyzingInfixSuggester and not the other lookup impleme=
ntations.
> If different Lookup implementations have different params as their constr=
uctors, these sort of issues will always keep happening. Maybe we should no=
t keep it generic and do instanceof checks and set params accordingly?



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org