lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF subversion and git services (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (LUCENE-6165) Change merging APIs to work on CodecReader instead of LeafReader
Date Thu, 08 Jan 2015 14:53:34 GMT

    [ https://issues.apache.org/jira/browse/LUCENE-6165?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14269398#comment-14269398
] 

ASF subversion and git services commented on LUCENE-6165:
---------------------------------------------------------

Commit 1650301 from [~rcmuir] in branch 'dev/trunk'
[ https://svn.apache.org/r1650301 ]

LUCENE-6165: Change merging APIs from LeafReader to CodecReader

> Change merging APIs to work on CodecReader instead of LeafReader
> ----------------------------------------------------------------
>
>                 Key: LUCENE-6165
>                 URL: https://issues.apache.org/jira/browse/LUCENE-6165
>             Project: Lucene - Core
>          Issue Type: Bug
>            Reporter: Robert Muir
>         Attachments: LUCENE-6165.patch
>
>
> Patch factors out "reader based on codec apis" and changes all merge policy/addIndexes
apis to use this. 
> If you want to do slow wrapping, you can still do it, just use SlowCodecReaderWrapper.wrap(LeafReader)
yourself (versus SegmentMerger doing it always if its not a SegmentReader).
> Also adds FilterCodecReader, to make it easier to start efficiently filtering on merge.
I cutover all the index splitters to this. This means they should be much much faster with
this patch, they just change the deletes as you expect, and the merge is as optimal as a normal
one.
> In other places, for now I think we should just do a rote conversion with SlowCodecReaderWrapper.wrap.
Its no slower than today, just explicit, and we can incrementally fix them to do the right
thing in the future rather than all at once.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message