lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF subversion and git services (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (SOLR-6715) ZkSolrResourceLoader constructors accept a parameter called "collection" but it should be "configName"
Date Fri, 16 Jan 2015 08:04:35 GMT

    [ https://issues.apache.org/jira/browse/SOLR-6715?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14279948#comment-14279948
] 

ASF subversion and git services commented on SOLR-6715:
-------------------------------------------------------

Commit 1652357 from [~anshumg] in branch 'dev/branches/branch_5x'
[ https://svn.apache.org/r1652357 ]

SOLR-6715: Removing duplicate CHANGES.txt entry (merge from trunk)

> ZkSolrResourceLoader constructors accept a parameter called "collection" but it should
be "configName"
> ------------------------------------------------------------------------------------------------------
>
>                 Key: SOLR-6715
>                 URL: https://issues.apache.org/jira/browse/SOLR-6715
>             Project: Solr
>          Issue Type: Bug
>            Reporter: Shalin Shekhar Mangar
>            Assignee: Shalin Shekhar Mangar
>            Priority: Trivial
>             Fix For: 5.0, Trunk
>
>         Attachments: SOLR-6715.patch
>
>
> {code}
> public ZkSolrResourceLoader(String instanceDir, String collection,
>       ZkController zooKeeperController);
> public ZkSolrResourceLoader(String instanceDir, String collection, ClassLoader parent,
>       Properties coreProperties, ZkController zooKeeperController);
> {code}
> The CloudConfigSetService created ZkSolrResourceLoader using the configName (which is
correct).
> We should renamed the param in ZkSolrResourceLoader to be configSetName and also rename
the "collectionZkPath" member to be "configSetZkPath"



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message