lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Robert Muir <rcm...@gmail.com>
Subject Re: svn commit: r1641902 - in /lucene/dev/trunk/lucene: core/src/test/org/apache/lucene/index/TestIndexWriter.java test-framework/src/java/org/apache/lucene/mockfile/FilterFileSystem.java test-framework/src/java/org/apache/lucene/util/TestUtil.java
Date Tue, 02 Dec 2014 17:13:43 GMT
On Tue, Dec 2, 2014 at 12:01 PM, Chris Hostetter
<hossman_lucene@fucit.org> wrote:

> my question: rather then assumeFalse() ~1/10 of the time (even when the
> underlying OS/FS is *NOT* windows) why not unwrap that (mock) windowsfs
> and still run the test using the real file system?
>
> Wouldn't that be trivial to do?  It doesn't seem any more complicated then
> what you had to add to implement "isWindowsFS" ... can't we just change
> those "isWindowsFS" boolean methods to something that returns the actual
> WindowsFS instance and calls getDelegate() on it?
>

Personally i am against this, we shouldn't make this method public!

The test has a problem in that it does not work on windows, but the
test framework doesnt need to become flaky to cater to this kind of
stuff.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message