lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Robert Muir (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (LUCENE-5972) Index too old/new is not a corruption
Date Mon, 22 Sep 2014 21:29:34 GMT

    [ https://issues.apache.org/jira/browse/LUCENE-5972?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14143857#comment-14143857
] 

Robert Muir commented on LUCENE-5972:
-------------------------------------

Looks good, can we remove this assert in both classes?

{code}
assert resourceDesc != null;
{code}

Such things do not belong in exceptions. Maybe while we are here, we can fix CorruptIndexException,
to not throw NPE if its 'message' is null.

Currently it has:
{code}
    super(message + " (resource=" + resourceDescription + ")", cause);
{code}

This can just be super(Objects.toString(message) + ...

> Index too old/new is not a corruption
> -------------------------------------
>
>                 Key: LUCENE-5972
>                 URL: https://issues.apache.org/jira/browse/LUCENE-5972
>             Project: Lucene - Core
>          Issue Type: Improvement
>            Reporter: Ryan Ernst
>         Attachments: LUCENE-5972.patch, LUCENE-5972.patch
>
>
> {{IndexFormatTooOldException}} and {{IndexFormatTooNewException}} both extend from {{CorruptIndexException}}.
 But this is not a corruption, it is simply an unsupported version of an index.  They should
just extend {{IOException}}.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message