lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Robert Muir (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (LUCENE-5906) Use Files.delete instead of File.delete + made up exception
Date Thu, 04 Sep 2014 10:39:51 GMT

    [ https://issues.apache.org/jira/browse/LUCENE-5906?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14121225#comment-14121225
] 

Robert Muir commented on LUCENE-5906:
-------------------------------------

Yeah, lemme try to fix that.

At first, when looking at lucene-core, i didnt think even IOUtils methods for deleting were
justified. Then i saw how many places were doing this, but tried to keep the minimal set here.
And you are right, i didnt want to duplicate with varargs. But we should just use asList to
avoid this (in close, too).



> Use Files.delete instead of File.delete + made up exception
> -----------------------------------------------------------
>
>                 Key: LUCENE-5906
>                 URL: https://issues.apache.org/jira/browse/LUCENE-5906
>             Project: Lucene - Core
>          Issue Type: Bug
>            Reporter: Robert Muir
>         Attachments: LUCENE-5906.patch, LUCENE-5906.patch
>
>
> We are on java7, if we cannot delete a file, this one returns a real exception as to
why.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message