lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ryan Ernst (JIRA)" <>
Subject [jira] [Updated] (LUCENE-5871) Simplify or remove use of Version in IndexWriterConfig
Date Thu, 07 Aug 2014 06:21:12 GMT


Ryan Ernst updated LUCENE-5871:

    Attachment: LUCENE-5871.patch

Thanks for all the ideas! This new patch removes {{shutdown()}} (as a public method), and
makes close() act based on {{commitOnClose}}.  There are a couple things still to fix:
* I'm unsure if TestIndexWriter.testCloseWhileMergeIsRunning is really doing anything (nothing
waits on mergeStarted? and the exc check of the old behavior was the only assertion?)
* TestIndexWriterMerging.testNoWaitClose hangs (I haven't looked at this at all yet)
* I haven't checked the latest changes against Solr yet.

> Simplify or remove use of Version in IndexWriterConfig
> ------------------------------------------------------
>                 Key: LUCENE-5871
>                 URL:
>             Project: Lucene - Core
>          Issue Type: Bug
>            Reporter: Ryan Ernst
>         Attachments: LUCENE-5871.patch, LUCENE-5871.patch
> {{IndexWriter}} currently uses Version from {{IndexWriterConfig}} to determine the semantics
of {{close()}}.  This is a trapdoor for users, as they often default to just sending Version.LUCENE_CURRENT
since they don't understand what it will be used for.  Instead, we should make the semantics
of close a direction option in IWC.

This message was sent by Atlassian JIRA

To unsubscribe, e-mail:
For additional commands, e-mail:

View raw message