lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Robert Muir (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (LUCENE-5871) Simplify or remove use of Version in IndexWriterConfig
Date Wed, 06 Aug 2014 15:22:12 GMT

    [ https://issues.apache.org/jira/browse/LUCENE-5871?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14087783#comment-14087783
] 

Robert Muir commented on LUCENE-5871:
-------------------------------------

{quote}
Actually, I rather like the change in semantics (from the current (on trunk) weird "throw
exception or not in close telling you if you lost changes", to "commit on close").

And ... the default makes me nervous: can we go back to 4.x's default? Ie, by default close
will wait for merges / commit, but you can disable this to make close == rollback by calling
IWC.setCommitOnClose(false).

If we do this, I think we need to fix close to call shutdown(true) when commitOnClose is true,
else rollback, and it no longer throws any exceptions about changes being lost
{quote}

+1

This gives the option for advanced users but prevents any scary mailing lists messages about
people losing documents because they passed VERSION_CURRENT.

> Simplify or remove use of Version in IndexWriterConfig
> ------------------------------------------------------
>
>                 Key: LUCENE-5871
>                 URL: https://issues.apache.org/jira/browse/LUCENE-5871
>             Project: Lucene - Core
>          Issue Type: Bug
>            Reporter: Ryan Ernst
>         Attachments: LUCENE-5871.patch
>
>
> {{IndexWriter}} currently uses Version from {{IndexWriterConfig}} to determine the semantics
of {{close()}}.  This is a trapdoor for users, as they often default to just sending Version.LUCENE_CURRENT
since they don't understand what it will be used for.  Instead, we should make the semantics
of close a direction option in IWC.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message