lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Robert Muir (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (LUCENE-5156) CompressingTermVectors termsEnum should probably not support seek-by-ord
Date Fri, 01 Aug 2014 22:03:40 GMT

    [ https://issues.apache.org/jira/browse/LUCENE-5156?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14083029#comment-14083029
] 

Robert Muir commented on LUCENE-5156:
-------------------------------------

Personally i would do such a thing with a FilterTerms + FilterReader. you just check if docid
== lastDocID and you have your cache thing.

But i dont think it should be in the default codec. I also happen to think term vectors arent
a good datastructure for highlighting anyway.

> CompressingTermVectors termsEnum should probably not support seek-by-ord
> ------------------------------------------------------------------------
>
>                 Key: LUCENE-5156
>                 URL: https://issues.apache.org/jira/browse/LUCENE-5156
>             Project: Lucene - Core
>          Issue Type: Bug
>            Reporter: Robert Muir
>             Fix For: 4.5, 5.0
>
>         Attachments: LUCENE-5156.patch
>
>
> Just like term vectors before it, it has a O(n) seek-by-term. 
> But this one also advertises a seek-by-ord, only this is also O(n).
> This could cause e.g. checkindex to be very slow, because if termsenum supports ord it
does a bunch of seeking tests. (Another solution would be to leave it, and add a boolean so
checkindex never does seeking tests for term vectors, only real fields).
> However, I think its also kinda a trap, in my opinion if seek-by-ord is supported anywhere,
you kinda expect it to be faster than linear time...?



--
This message was sent by Atlassian JIRA
(v6.2#6252)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message