lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Mark Miller <markrmil...@gmail.com>
Subject Re: Using a patch review tool for Lucene / Solr development.
Date Thu, 10 Jul 2014 21:14:16 GMT
bq. Have you considered using GitHub instead?

I have, and I'm even less comfortable spreading stuff that is not in JIRA
there, since it's not officially Apache sanctioned. I wish Apache would
make a deal with GitHub to do first class GitHub for us, as they do many
companies, but Apache seems to have a list of arcane reasons why that's
impossible. But without that, I want to keep important history on official
Apache systems.

I just gave up using git with svn for like the 10th time as well. I always
forget and try again, but it's not worth it. Until Git is first class for
the project, I'll keep coming back to SVN only.


On Thu, Jul 10, 2014 at 2:54 PM, david.w.smiley@gmail.com <
david.w.smiley@gmail.com> wrote:

> On Wed, Jul 9, 2014 at 1:34 PM, Mark Miller <markrmiller@gmail.com> wrote:
>
>> A few months ago, I filed INFRA JIRA issue to add the Lucene project to
>> review board (https://reviews.apache.org) and it was just resolved (
>> https://issues.apache.org/jira/browse/INFRA-7630).
>>
>
> Awesome.
>
>
>> I’m not the biggest fan of review board, but it’s well supported by
>> Apache and is sufficient at the key points for a patch review tool I think.
>>
>
> Have you considered using GitHub instead?  I’m using that with my GSOC
> student, Varun Shenoy on his fork of the lucene-solr mirror on GitHub.
>  That is, he has a branch and I’m commenting on his commits.  No need to
> upload diff files or have a login to yet another system (doesn’t everyone
> have a GitHub account by now?).
>
>
>> I don’t think we should make this mandatory and that it should just be
>> treated as an additional, optional resource, but I wanted to alert people
>> to it’s existence and perhaps start a discussion around a few points.
>>
>> * I’ve been sold more and more over time of the advantages of a review
>> tool, especially for large patches. The ability to comment at code points
>> and easily view differences between successive patches is super useful.
>>
>> * I don’t know how I feel about moving comments and discussion for
>> patches out of JIRA and into review board. I’m not sure what kind of
>> integration there is.
>>
>> I’m using https://issues.apache.org/jira/browse/SOLR-5656 as a first
>> trial issue: https://reviews.apache.org/r/23371/
>
>
> I think it’s fine that line-number oriented discussion isn’t in JIRA so
> long as that the relevant JIRA issue links to the discussion so people know
> where to look.  It would be nice if the high level discussion could be kept
> in JIRA, which is more searchable (e.g. McCandless’s jirasearch) and
> observable by interested parties.
>
> ~ David
>



-- 
- Mark

http://about.me/markrmiller

Mime
View raw message