lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Dawid Weiss (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (SOLR-6119) TestReplicationHandler attempts to remove open folders
Date Tue, 03 Jun 2014 06:23:02 GMT

    [ https://issues.apache.org/jira/browse/SOLR-6119?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14016263#comment-14016263
] 

Dawid Weiss commented on SOLR-6119:
-----------------------------------

I've committed your latest patch, Varun, thanks. I still don't think SnapPuller should be
working after 
{code}
masterJetty.stop();
masterClient.shutdown();
{code}
but it may be my misunderstanding of Solr's infrastructure (I don't work with Solr much).

Thanks for help!

> TestReplicationHandler attempts to remove open folders
> ------------------------------------------------------
>
>                 Key: SOLR-6119
>                 URL: https://issues.apache.org/jira/browse/SOLR-6119
>             Project: Solr
>          Issue Type: Bug
>            Reporter: Dawid Weiss
>            Priority: Minor
>         Attachments: SOLR-6119.patch, SOLR-6119.patch, SOLR-6119.patch, SOLR-6119.patch,
SOLR-6119.patch
>
>
> TestReplicationHandler has a weird logic around the 'snapDir' variable. It attempts to
remove snapshot folders, even though they're not closed yet. My recent patch uncovered the
bug but I don't know how to fix it cleanly -- the test itself seems to be very fragile (for
example I don't understand the 'namedBackup' variable which is always set to true, yet there
are conditionals around it).



--
This message was sent by Atlassian JIRA
(v6.2#6252)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message