lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Robert Muir (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (LUCENE-5650) createTempDir and associated functions no longer create java.io.tmpdir
Date Tue, 06 May 2014 21:40:17 GMT

    [ https://issues.apache.org/jira/browse/LUCENE-5650?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13991172#comment-13991172
] 

Robert Muir commented on LUCENE-5650:
-------------------------------------

The main upside is it increases sandboxing: being lazy and letting tests read/write to CWD
means you have a higher possibility of failures because tests "interfere with each other".
When they make their own temp dirs this doesnt happen.

But, as soon as a logging framework gets in my way on something, i drop out. I just cant deal
with them :)

Maybe someone else can follow thru the final inch so we can ban this, or at least only allow
it for the modules that aren't fixed.

> createTempDir and associated functions no longer create java.io.tmpdir
> ----------------------------------------------------------------------
>
>                 Key: LUCENE-5650
>                 URL: https://issues.apache.org/jira/browse/LUCENE-5650
>             Project: Lucene - Core
>          Issue Type: Bug
>            Reporter: Ryan Ernst
>            Assignee: Dawid Weiss
>
> The recent refactoring to all the create temp file/dir functions (which is great!) has
a minor regression from what existed before.  With the old {{LuceneTestCase.TEMP_DIR}}, the
directory was created if it did not exist.  So, if you set {{java.io.tmpdir}} to {{"./temp"}},
then it would create that dir within the per jvm working dir.  However, {{getBaseTempDirForClass()}}
now does asserts that check the dir exists, is a dir, and is writeable.
> Lucene uses {{"."}} as {{java.io.tmpdir}}.  Then in the test security manager, the per
jvm cwd has read/write/execute permissions.  However, this allows tests to write to their
cwd, which I'm trying to protect against (by setting cwd to read/execute in my test security
manager).



--
This message was sent by Atlassian JIRA
(v6.2#6252)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message