lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Parvesh Garg (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (SOLR-5228) Deprecate <fields> and <types> tags in schema.xml
Date Mon, 05 May 2014 07:23:21 GMT

    [ https://issues.apache.org/jira/browse/SOLR-5228?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13989326#comment-13989326
] 

Parvesh Garg commented on SOLR-5228:
------------------------------------

One use case for keeping sections is to have the capability of <xi:include functionality.
We have a lot of cores and use this for common fields and field types that we don't want anyone
to modify per core. 

<xi:includes take only well formed xml (meaning they need a root element) and make the
included xml a child element at the place where the directive is put. We already struggled
with not being able to put <copyField and <similarity in a common file as they are directly
under the root element <schema.

My understanding of <xi:include could be wrong, happy to get corrected. If not and we still
want to remove these sections, can there be another way to provide an include directive. Something
like commons-configuration does.

> Deprecate <fields> and <types> tags in schema.xml
> -------------------------------------------------
>
>                 Key: SOLR-5228
>                 URL: https://issues.apache.org/jira/browse/SOLR-5228
>             Project: Solr
>          Issue Type: Improvement
>          Components: Schema and Analysis
>            Reporter: Hoss Man
>            Assignee: Erick Erickson
>             Fix For: 4.8, 5.0
>
>         Attachments: SOLR-5228.patch, SOLR-5228.patch
>
>
> On the solr-user mailing list, Nutan recently mentioned spending days trying to track
down a problem that turned out to be because he had attempted to add a {{<dynamicField
.. />}} that was outside of the {{<fields>}} block in his schema.xml -- Solr was
just silently ignoring it.
> We have made improvements in other areas of config validation by generating statup errors
when tags/attributes are found that are not expected -- but in this case i think we should
just stop expecting/requiring that the {{<fields>}} and {{<types>}} tags will
be used to group these sorts of things.  I think schema.xml parsing should just start ignoring
them and only care about finding the {{<field>}}, {{<dynamicField>}}, and {{<fieldType>}}
tags wherever they may be.
> If people want to keep using them, fine.  If people want to mix fieldTypes and fields
side by side (perhaps specify a fieldType, then list all the fields using it) fine.  I don't
see any value in forcing people to use them, but we definitely shouldn't leave things the
way they are with otherwise perfectly valid field/type declarations being silently ignored.
> ---
> I'll take this on unless i see any objections.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message