lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Aaron LaBella (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (SOLR-6013) Fix method visibility of Evaluator, refactor DateFormatEvaluator for extensibility
Date Mon, 28 Apr 2014 13:11:15 GMT

     [ https://issues.apache.org/jira/browse/SOLR-6013?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Aaron LaBella updated SOLR-6013:
--------------------------------

    Attachment: 0001-change-method-access-to-protected.patch

Thanks Shalin,

I'm attaching another patch to change the method accessors to protected (instead of public)
and marked the methods as lucene.experimental.  Let me know if there's anything else.  Otherwise,
can you, or someone else commit/push these patches into the 4.x branch so it makes the next
release?

Thanks

> Fix method visibility of Evaluator, refactor DateFormatEvaluator for extensibility
> ----------------------------------------------------------------------------------
>
>                 Key: SOLR-6013
>                 URL: https://issues.apache.org/jira/browse/SOLR-6013
>             Project: Solr
>          Issue Type: Improvement
>          Components: contrib - DataImportHandler
>    Affects Versions: 4.7
>            Reporter: Aaron LaBella
>             Fix For: 4.9
>
>         Attachments: 0001-add-getters-for-datemathparser.patch, 0001-change-method-access-to-protected.patch,
0001-change-method-variable-visibility-and-refactor-for-extensibility.patch
>
>   Original Estimate: 1h
>  Remaining Estimate: 1h
>
> This is similar to issue 5981, the Evaluator class is declared as abstract, yet the parseParams
method is package private?  Surely this is an oversight, as I wouldn't expect everyone writing
their own evaluators to have to deal with parsing the parameters.
> Similarly, I needed to refactor DateFormatEvaluator because I need to do some custom
date math/parsing and it wasn't written in a way that I can extend it.
> Please review/apply my attached patch to the next version of Solr, ie: 4.8 or 4.9 if
I must wait.
> Thanks!



--
This message was sent by Atlassian JIRA
(v6.2#6252)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message