Mailing-List: contact dev-help@lucene.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@lucene.apache.org
Date: Mon, 10 Mar 2014 08:41:44 +0000 (UTC)
From: "Noble Paul (JIRA)" <jira@apache.org>
To: dev@lucene.apache.org
Message-ID: <JIRA.12696469.1392963924300.34119.1394440904865@arcas>
In-Reply-To: <JIRA.12696469.1392963924300@arcas>
References: <JIRA.12696469.1392963924300@arcas>
Subject: [jira] [Commented] (SOLR-5762) SOLR-5658 broke backward
 compatibility of Javabin format
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/SOLR-5762?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13925564#comment-13925564 ] 

Noble Paul commented on SOLR-5762:
----------------------------------

Solr behaves a lot like a web container where the various components determine the parameters accepted. In any given request various components can participate in fulfilling the request. Erroring out for unexpected params means that we will have to keep a database of all parameters from all components. It is going to cause a lot of problems for us devs as well as the suers

> SOLR-5658 broke backward compatibility of Javabin format
> --------------------------------------------------------
>
>                 Key: SOLR-5762
>                 URL: https://issues.apache.org/jira/browse/SOLR-5762
>             Project: Solr
>          Issue Type: Bug
>    Affects Versions: 4.6.1, 4.7
>            Reporter: Noble Paul
>             Fix For: 4.7, 4.8, 5.0
>
>         Attachments: SOLR-5672.patch, SOLR-5762-test.patch, SOLR-5762.patch, updateReq_4_5.bin
>
>
> In SOLR-5658 the docsMap entry was changed from a Map to List<Map> this broke  back compat of older clients with 4.6.1 and later
> {noformat}
> ERROR - 2014-02-20 21:28:36.332; org.apache.solr.common.SolrException; java.lang.ClassCastException: java.util.LinkedHashMap cannot be cast to java.util.List
>         at org.apache.solr.client.solrj.request.JavaBinUpdateRequestCodec.unmarshal(JavaBinUpdateRequestCodec.java:188)
>         at org.apache.solr.handler.loader.JavabinLoader.parseAndLoadDocs(JavabinLoader.java:106)
>         at org.apache.solr.handler.loader.JavabinLoader.load(JavabinLoader.java:58)
>         at org.apache.solr.handler.UpdateRequestHandler$1.load(UpdateRequestHandler.java:92)
>         at org.apache.solr.handler.ContentStreamHandlerBase.handleRequestBody(ContentStreamHandlerBase.java:74)
>         at org.apache.solr.handler.RequestHandlerBase.handleRequest(RequestHandlerBase.java:135)
>         at org.apache.solr.core.SolrCore.execute(SolrCore.java:1859)
>         at org.apache.solr.servlet.SolrDispatchFilter.execute(SolrDispatchFilter.java:721)
>         at org.apache.solr.servlet.SolrDispatchFilter.doFilter(SolrDispatchFilter.java:417)
>         at org.apache.solr.servlet.SolrDispatchFilter.doFilter(SolrDispatchFilter.java:201)
>         at org.eclipse.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1419)
>         at org.eclipse.jetty.servlet.ServletHandler.doHandle(ServletHandler.java:455)
>         at org.eclipse.jetty.server.handler.ScopedHandler.handle(ScopedHandler.java:137)
>         at org.eclipse.jetty.security.SecurityHandler.handle(SecurityHandler.java:557)
>         at org.eclipse.jetty.server.session.SessionHandler.doHandle(SessionHandler.java:231)
>         at org.eclipse.jetty.server.handler.ContextHandler.doHandle(ContextHandler.java:1075)
>         at org.eclipse.jetty.servlet.ServletHandler.doScope(ServletHandler.java:384)
>         at org.eclipse.jetty.server.session.SessionHandler.doScope(SessionHandler.java:193)
>         at org.eclipse.jetty.server.handler.ContextHandler.doScope(ContextHandler.java:1009)
>         at org.eclipse.jetty.server.handler.ScopedHandler.handle(ScopedHandler.java:135)
>         at org.eclipse.jetty.server.handler.ContextHandlerCollection.handle(ContextHandlerCollection.java:255)
>         at org.eclipse.jetty.server.handler.HandlerCollection.handle(HandlerCollection.java:154)
>         at org.eclipse.jetty.server.handler.HandlerWrapper.handle(HandlerWrapper.java:116)
>         at org.eclipse.jetty.server.Server.handle(Server.java:368)
>         at org.eclipse.jetty.server.AbstractHttpConnection.handleRequest(AbstractHttpConnection.java:489)
>         at org.eclipse.jetty.server.BlockingHttpConnection.handleRequest(BlockingHttpConnection.java:53)
>         at org.eclipse.jetty.server.AbstractHttpConnection.content(AbstractHttpConnection.java:953)
>         at org.eclipse.jetty.server.AbstractHttpConnection$RequestHandler.content(AbstractHttpConnection.java:1014)
>         at org.eclipse.jetty.http.HttpParser.parseNext(HttpParser.java:953)
>         at org.eclipse.jetty.http.HttpParser.parseAvailable(HttpParser.java:240)
>         at org.eclipse.jetty.server.BlockingHttpConnection.handle(BlockingHttpConnection.java:72)
>         at org.eclipse.jetty.server.bio.SocketConnector$ConnectorEndPoint.run(SocketConnector.java:264)
>         at org.eclipse.jetty.util.thread.QueuedThreadPool.runJob(QueuedThreadPool.java:608)
>         at org.eclipse.jetty.util.thread.QueuedThreadPool$3.run(QueuedThreadPool.java:543)
>         at java.lang.Thread.run(Thread.java:744)
> {noformat}


--
This message was sent by Atlassian JIRA
(v6.2#6252)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org