lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Robert Muir (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (LUCENE-5559) Argument validation for TokenFilters having numeric constructor parameter(s)
Date Fri, 28 Mar 2014 18:57:15 GMT

    [ https://issues.apache.org/jira/browse/LUCENE-5559?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13951236#comment-13951236
] 

Robert Muir commented on LUCENE-5559:
-------------------------------------

I don't think the factories need anything if you will already hit the check from the Filter
itself.

But if the factory would crash in some way that is confusing on certain inputs, then it would
need a check too.

> Argument validation for TokenFilters having numeric constructor parameter(s)
> ----------------------------------------------------------------------------
>
>                 Key: LUCENE-5559
>                 URL: https://issues.apache.org/jira/browse/LUCENE-5559
>             Project: Lucene - Core
>          Issue Type: Improvement
>          Components: modules/analysis
>    Affects Versions: 4.7
>            Reporter: Ahmet Arslan
>            Priority: Minor
>             Fix For: 4.8
>
>
> Some TokenFilters have numeric arguments in their constructors. They should throw {{IllegalArgumentException}}
for negative or meaningless values. 
> Here is some examples that demonstrates invalid/meaningless arguments :
> {code:xml}
>  <filter class="solr.LimitTokenCountFilterFactory" maxTokenCount="-10" />
> {code}
> {code:xml}
>  <filter class="solr.LengthFilterFactory" min="-5" max="-1" />
> {code}
> {code:xml}
>  <filter class="solr.LimitTokenPositionFilterFactory" maxTokenPosition="-3" />
> {code}



--
This message was sent by Atlassian JIRA
(v6.2#6252)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message