lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Uwe Schindler (JIRA)" <>
Subject [jira] [Updated] (LUCENE-5537) Fix version check in TestCheckIndexes
Date Tue, 18 Mar 2014 10:50:42 GMT


Uwe Schindler updated LUCENE-5537:

    Attachment: LUCENE-5537.patch

- Moves test to a separate file oal.util.TestConstants
- 2 test cases: One just checks that constants LUCENE_VERSION and LUCENE_MAIN_VERSION match,
the other test just checks test setup (if ran via ANT)
- I removed the ALPHA/BETA handling in those version numbers. This was completely broken.
If we have LUCENE 5.0 BETA, we should first decide how to declare LUCENE_MAIN_VERSION for
those, to be able to change index format, if not finalized.

> Fix version check in TestCheckIndexes
> -------------------------------------
>                 Key: LUCENE-5537
>                 URL:
>             Project: Lucene - Core
>          Issue Type: Bug
>          Components: core/other
>    Affects Versions: 4.7
>            Reporter: Uwe Schindler
>            Assignee: Uwe Schindler
>            Priority: Blocker
>             Fix For: 4.8, 5.0, 4.7.1
>         Attachments: LUCENE-5537.patch
> The crazy version check in TestCheckIndexes is broken. Whenever it fails, it requires
a horrible amount of understanding:
> - error messages are useless
> - you don't know what it really checks and why (no documentation)
> In addition, we have no clear workflow how to handle version updates:
> - In 4.6 series we never set the dev.version in common-build to 4.6.1, it always stayed
4.6. The test worked therefore, because the LUCENE_MAIN_VERSION (which is always "x.y") was
> - In 4.7 [~steve_rowe] changed the version to the real release version in the branch.
The test failed because of this change (LUCENE_MAIN_VERSION was not identical as the dotted
bugfix version)
> We should in any case fix the test:
> - move it out of TestCheckIndex, it should be in oal.util.TestConstants
> - Be more verbose on loggin
> - Remove special cases (leftovers from 4.0-BETA) where we did crazy stuff to make this
test pass in alphas and betas.
> - Only add a check to LUCENE_MAIN_VERSION that it is in format "x.y" (which is required
by Lucene index format), and only check that it is the prefix of the real version as reported
by common_build.xml.
> We should also document and write down when we change the version numbers. I would prefer
to use the variant of Lucene 4.6: never change the version number in common-build and "override"
it while building artifacts.

This message was sent by Atlassian JIRA

To unsubscribe, e-mail:
For additional commands, e-mail:

View raw message