lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Mark Miller (JIRA)" <>
Subject [jira] [Commented] (SOLR-5859) Harden the Overseer restart mechanism
Date Sun, 30 Mar 2014 20:09:15 GMT


Mark Miller commented on SOLR-5859:

Yes, very nice change. This approach is great.

Patch looks good, but some nits with the current version listed below:

bq. OCP

We info log closing OCP - we probably should not abbreviate it though, a user won't know what
it is.

bq.   } else if( QUIT.equals(operation)){

  String getId(){
    return myId;

There are also some project formatting violations - eg spacing, missing new line:     

{code}"IsClosed  :{} , {}", isClosed, this);
    log.warn("OverseerCollectionProcessor.processMessage : "+ operation + " , "+ message.toString());

I think both of those are wrong - should be one log line under debug.

bq. import;

Unused import added.

> Harden the Overseer restart mechanism
> -------------------------------------
>                 Key: SOLR-5859
>                 URL:
>             Project: Solr
>          Issue Type: Improvement
>            Reporter: Noble Paul
>            Assignee: Noble Paul
>         Attachments: SOLR-5859.patch, SOLR-5859.patch
> SOLR-5476 depends on Overseer restart.The current strategy is to remove the zk node for
leader election and wait for STATUS_UPDATE_DELAY +100 ms and  start the new overseer.
> Though overseer ops are short running,  it is not a 100% foolproof strategy because if
an operation takes longer than the wait period there can be race condition. 

This message was sent by Atlassian JIRA

To unsubscribe, e-mail:
For additional commands, e-mail:

View raw message