lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Michael McCandless (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (LUCENE-5414) suggest module should not depend on expression module
Date Thu, 23 Jan 2014 20:51:42 GMT

    [ https://issues.apache.org/jira/browse/LUCENE-5414?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13880338#comment-13880338
] 

Michael McCandless commented on LUCENE-5414:
--------------------------------------------

+1

> suggest module should not depend on expression module
> -----------------------------------------------------
>
>                 Key: LUCENE-5414
>                 URL: https://issues.apache.org/jira/browse/LUCENE-5414
>             Project: Lucene - Core
>          Issue Type: Wish
>    Affects Versions: 4.6, 5.0
>            Reporter: Simon Willnauer
>             Fix For: 5.0, 4.7
>
>         Attachments: LUCENE-5414.patch
>
>
> Currently our suggest module depends on the expression module just because the DocumentExpressionDictionary
provides some util ctor to pass in an expression directly. That is a lot of dependency for
little value IMO and pulls in lots of JARs. DocumentExpressionDictionary should only take
a ValueSource instead.



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message