lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF subversion and git services (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (LUCENE-5398) NormValueSource unable to read long field norm
Date Fri, 31 Jan 2014 12:22:09 GMT

    [ https://issues.apache.org/jira/browse/LUCENE-5398?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13887684#comment-13887684
] 

ASF subversion and git services commented on LUCENE-5398:
---------------------------------------------------------

Commit 1563120 from [~mikemccand] in branch 'dev/branches/branch_4x'
[ https://svn.apache.org/r1563120 ]

LUCENE-5398: remove invalid byte cast in NormValueSource, since TFIDFSimilarity now allows
for norms larger than one byte

> NormValueSource unable to read long field norm
> ----------------------------------------------
>
>                 Key: LUCENE-5398
>                 URL: https://issues.apache.org/jira/browse/LUCENE-5398
>             Project: Lucene - Core
>          Issue Type: Bug
>          Components: core/query/scoring
>    Affects Versions: 4.6
>         Environment: Ubuntu 12.04
>            Reporter: Peng Cheng
>            Priority: Trivial
>             Fix For: 5.0, 4.7
>
>         Attachments: LUCENE-5398.patch, NormValueSource.java, TestValueSourcesWithNonByteNormEncoding.java
>
>   Original Estimate: 1h
>  Remaining Estimate: 1h
>
> Previous Lucene implementation store field norms of all documents in memory, float values
are therefore encoded into byte to minimize memory consumption.
> Recent release no longer have this constraint (see LUCENE-5078, and discussion at http://lucene.markmail.org/message/jtwit3pwu5oiqr2h),
users are encouraged to implement their own encodeNormValue() to encode them into/decode from
any type including int, byte and long, to fulfil their request for precision.
> But the legacy NormValueSource still typecast any long encoding into byte, as seen in
line 74 in the java file, making any TFIDFSimilarity using more accurate encoding useless.
> It should be removed for the greater good.



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message