lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Robert Muir (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (LUCENE-5388) Eliminate construction over readers for Tokenizer
Date Wed, 08 Jan 2014 13:13:56 GMT

    [ https://issues.apache.org/jira/browse/LUCENE-5388?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13865401#comment-13865401
] 

Robert Muir commented on LUCENE-5388:
-------------------------------------

Benson, he just means the patch would only be committed to trunk. I agree with this...

> Eliminate construction over readers for Tokenizer
> -------------------------------------------------
>
>                 Key: LUCENE-5388
>                 URL: https://issues.apache.org/jira/browse/LUCENE-5388
>             Project: Lucene - Core
>          Issue Type: Improvement
>          Components: core/other
>            Reporter: Benson Margulies
>
> In the modern world, Tokenizers are intended to be reusable, with input supplied via
#setReader. The constructors that take Reader are a vestige. Worse yet, they invite people
to make mistakes in handling the reader that tangle them up with the state machine in Tokenizer.
The sensible thing is to eliminate these ctors, and force setReader usage.



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message