lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF subversion and git services (JIRA)" <>
Subject [jira] [Commented] (LUCENE-5228) IndexWriter.addIndexes copies raw files but acquires no locks
Date Sat, 25 Jan 2014 22:09:38 GMT


ASF subversion and git services commented on LUCENE-5228:

Commit 1561412 from [~mikemccand] in branch 'dev/branches/branch_4x'
[ ]

LUCENE-5228: IndexWriter.addIndexes(Directory[]) now acquires the IW write lock on the incoming
indices to ensure there are no active IndexWriters in those directories

> IndexWriter.addIndexes copies raw files but acquires no locks
> -------------------------------------------------------------
>                 Key: LUCENE-5228
>                 URL:
>             Project: Lucene - Core
>          Issue Type: Bug
>            Reporter: Robert Muir
>            Assignee: Michael McCandless
>             Fix For: 5.0, 4.7
>         Attachments: LUCENE-5228.patch
> I see stuff like: "merge problem with lucene 3 and 4 indices" (from solr users list),
and cannot even think how to respond to these users because so many things can go wrong with
> it currently has in its javadocs:
> NOTE: the index in each Directory must not be changed (opened by a writer) while this
method is running. This method does not acquire a write lock in each input Directory, so it
is up to the caller to enforce this. 
> This method should be acquiring locks: its copying *RAW FILES*. Otherwise we should remove
it. If someone doesnt like that, or is mad because its 10ns slower, they can use NoLockFactory.

This message was sent by Atlassian JIRA

To unsubscribe, e-mail:
For additional commands, e-mail:

View raw message