Return-Path: X-Original-To: apmail-lucene-dev-archive@www.apache.org Delivered-To: apmail-lucene-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 2410610959 for ; Sun, 1 Dec 2013 17:57:37 +0000 (UTC) Received: (qmail 95066 invoked by uid 500); 1 Dec 2013 17:57:35 -0000 Delivered-To: apmail-lucene-dev-archive@lucene.apache.org Received: (qmail 94938 invoked by uid 500); 1 Dec 2013 17:57:35 -0000 Mailing-List: contact dev-help@lucene.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@lucene.apache.org Delivered-To: mailing list dev@lucene.apache.org Received: (qmail 94930 invoked by uid 99); 1 Dec 2013 17:57:35 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 01 Dec 2013 17:57:35 +0000 Date: Sun, 1 Dec 2013 17:57:35 +0000 (UTC) From: "Robert Muir (JIRA)" To: dev@lucene.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (SOLR-5518) Move editing config files into a new handler MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/SOLR-5518?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13836080#comment-13836080 ] Robert Muir commented on SOLR-5518: ----------------------------------- Maybe just leave ShowFileHandler alone on this issue?! I don't think it should be mixed in with this editing stuff... I dont see a need for a base class shared between the two anyway. This seems like it can just be 2 static methods. > Move editing config files into a new handler > -------------------------------------------- > > Key: SOLR-5518 > URL: https://issues.apache.org/jira/browse/SOLR-5518 > Project: Solr > Issue Type: Improvement > Affects Versions: 5.0, 4.7 > Reporter: Erick Erickson > Assignee: Erick Erickson > Priority: Blocker > Attachments: SOLR-5518.patch > > > See SOLR-5287. Uwe Schindler pointed out that writing files the way 5287 is a security vulnerability and that disabling it should be the norm. Subsequent discussion came up with this idea. > Writing arbitrary config files should NOT be on by default. > We'll also incorporate Mark's idea of testing XML files before writing anywhere. -- This message was sent by Atlassian JIRA (v6.1#6144) --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org For additional commands, e-mail: dev-help@lucene.apache.org