lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Yonik Seeley (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (LUCENE-5335) Change raw Map type to Map<String,Object> for ValueSource context
Date Thu, 07 Nov 2013 23:35:18 GMT

    [ https://issues.apache.org/jira/browse/LUCENE-5335?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13816790#comment-13816790
] 

Yonik Seeley commented on LUCENE-5335:
--------------------------------------

bq. I would have expected problems if a key existed somewhere that wasn't a String.

On a quick look, you only converted getValues and not createWeight?  Perhaps that's why it
compiles (but should get an error at runtime if we have good enough test coverage).

SumTotalTermFreqValueSource is one example of where "this" is very conveniently used as a
key.

> Change raw Map type to Map<String,Object> for ValueSource context
> -----------------------------------------------------------------
>
>                 Key: LUCENE-5335
>                 URL: https://issues.apache.org/jira/browse/LUCENE-5335
>             Project: Lucene - Core
>          Issue Type: Sub-task
>            Reporter: Ryan Ernst
>         Attachments: LUCENE-5335.patch
>
>
> Just as the title says.  Simple refactoring.



--
This message was sent by Atlassian JIRA
(v6.1#6144)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message