lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Simon Willnauer <simon.willna...@gmail.com>
Subject Re: [VOTE] Lucene / Solr 4.6.0 Take 3
Date Thu, 21 Nov 2013 15:43:40 GMT
yeah I got the same feeling though. Yet I'am on it and I think it's a
test bug. The reader is just empty since all docs have been deleted. I
will commit a fix for this, no need to respin.

On Thu, Nov 21, 2013 at 4:12 PM, Steve Rowe <sarowe@gmail.com> wrote:
> +0 to not respin.  If I had bandwidth I’d try to figure out if this is a test bug,
or isolated to the suggest module: in either of those cases I’d be +1 to not respin.  -
Steve
>
> On Nov 21, 2013, at 10:03 AM, Simon Willnauer <simon.willnauer@gmail.com> wrote:
>
>> I am not sure if we should respin for this one. I'd rather go and fix
>> this for 4.7 or 4.6.1
>>
>> what's your take?
>>
>> simon
>>
>> On Thu, Nov 21, 2013 at 3:50 PM, Steve Rowe <sarowe@gmail.com> wrote:
>>> Erick, if by “4.6 label” you mean “4.6 svn tag”, the release process
has this happening after the vote, not before, since otherwise you have to move the tag when
an RC fails: <http://wiki.apache.org/lucene-java/ReleaseTodo#Publishing>
>>>
>>> Steve
>>>
>>> On Nov 21, 2013, at 9:34 AM, Erick Erickson <erickerickson@gmail.com> wrote:
>>>
>>>> Same thing happens on my macbook FWIW, running on 4x. BTW, I didn't see a
4.6 label, am I missing something?
>>>>
>>>> Erick
>>>>
>>>>
>>>> On Thu, Nov 21, 2013 at 8:39 AM, Steve Rowe <sarowe@gmail.com> wrote:
>>>> Smoke tester found a reproducible test failure in lucene/suggest, under both
java6 and java7 on my Macbook Pro - I don’t have time to investigate today - here’s the
java7 failure:
>>>>
>>>> ——
>>>>   [junit4] Suite: org.apache.lucene.search.suggest.DocumentExpressionDictionaryTest
>>>>   [junit4]   2> NOTE: reproduce with: ant test  -Dtestcase=DocumentExpressionDictionaryTest
-Dtests.method=testWithDeletions -Dtests.seed=6ACAAA8898D1B1C8 -Dtests.slow=true -Dtests.locale=sk
-Dtests.timezone=Indian/Maldives -Dtests.file.encoding=US-ASCII
>>>>   [junit4] ERROR   0.86s | DocumentExpressionDictionaryTest.testWithDeletions
<<<
>>>>   [junit4]    > Throwable #1: java.lang.IllegalArgumentException: Reader
has to have at least one leaf
>>>>   [junit4]    >        at __randomizedtesting.SeedInfo.seed([6ACAAA8898D1B1C8:4343D2A86CE05A8]:0)
>>>>   [junit4]    >        at org.apache.lucene.search.suggest.DocumentExpressionDictionary$DocumentExpressionInputIterator.<init>(DocumentExpressionDictionary.java:111)
>>>>   [junit4]    >        at org.apache.lucene.search.suggest.DocumentExpressionDictionary.getWordsIterator(DocumentExpressionDictionary.java:95)
>>>>   [junit4]    >        at org.apache.lucene.search.suggest.DocumentExpressionDictionaryTest.testWithDeletions(DocumentExpressionDictionaryTest.java:184)
>>>>   [junit4]    >        at java.lang.Thread.run(Thread.java:724)
>>>>   [junit4]   2> NOTE: test params are: codec=Lucene45, sim=DefaultSimilarity,
locale=sk, timezone=Indian/Maldives
>>>>   [junit4]   2> NOTE: Mac OS X 10.9 x86_64/Oracle Corporation 1.7.0_25
(64-bit)/cpus=8,threads=1,free=5635480,total=18587648
>>>>   [junit4]   2> NOTE: All tests run in this JVM: [DocumentExpressionDictionaryTest]
>>>>   [junit4] Completed in 1.29s, 1 test, 1 error <<< FAILURES!
>>>> ——
>>>>
>>>> Steve
>>>>
>>>> On Nov 19, 2013, at 9:11 AM, Simon Willnauer <simon.willnauer@gmail.com>
wrote:
>>>>
>>>>> Please vote for the third Release Candidate for Lucene/Solr 4.6.0
>>>>> (don't be irritated by that this is RC4 I build on that I didn't put
>>>>> up for vote)
>>>>>
>>>>> This RC includes some additional fixes related to Changes.html that
>>>>> were committed in the last days like SOLR-5397 as well as:
>>>>>
>>>>> SOLR-5464: Add option to ConcurrentSolrServer to stream pure delete requests.
>>>>> SOLR-5465: SolrCmdDistributor retry logic has a concurrency race bug.
>>>>> SOLR-5452: Do not attempt to proxy internal update requests.
>>>>>
>>>>> you can download it here:
>>>>> http://people.apache.org/~simonw/staging_area/lucene-solr-4.6.0-RC4-rev1543363/
>>>>>
>>>>> or run the smoke tester directly with this commandline (don't forget
>>>>> to set JAVA6_HOME etc.):
>>>>>
>>>>> python3.2 -u dev-tools/scripts/smokeTestRelease.py
>>>>> http://people.apache.org/~simonw/staging_area/lucene-solr-4.6.0-RC4-rev1543363/
>>>>> 1543363 4.6.0 /tmp/smoke_test_4_6
>>>>>
>>>>> I integrated the RC into Elasticsearch and all tests pass:
>>>>>
>>>>> https://github.com/s1monw/elasticsearch/tree/upgrade_lucene_4_6
>>>>>
>>>>> Smoketester said: SUCCESS! [1:08:00.010026]
>>>>>
>>>>> here is my +1
>>>>>
>>>>> ---------------------------------------------------------------------
>>>>> To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
>>>>> For additional commands, e-mail: dev-help@lucene.apache.org
>>>>>
>>>>
>>>>
>>>> ---------------------------------------------------------------------
>>>> To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
>>>> For additional commands, e-mail: dev-help@lucene.apache.org
>>>>
>>>>
>>>
>>>
>>> ---------------------------------------------------------------------
>>> To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
>>> For additional commands, e-mail: dev-help@lucene.apache.org
>>>
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
>> For additional commands, e-mail: dev-help@lucene.apache.org
>>
>

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message