lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Mark Miller (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (SOLR-5342) In some places, when a caught exception is re-thrown, the original exception is not included
Date Mon, 14 Oct 2013 00:07:42 GMT

    [ https://issues.apache.org/jira/browse/SOLR-5342?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13793855#comment-13793855
] 

Mark Miller commented on SOLR-5342:
-----------------------------------

Nice work Shawn! The one change I'd make personally is where you print the stack trace before
the summarized printout - I'd prefer to see the summary logging first, than the detailed stack
trace.

> In some places, when a caught exception is re-thrown, the original exception is not included
> --------------------------------------------------------------------------------------------
>
>                 Key: SOLR-5342
>                 URL: https://issues.apache.org/jira/browse/SOLR-5342
>             Project: Solr
>          Issue Type: Improvement
>    Affects Versions: 4.5
>            Reporter: Shawn Heisey
>            Assignee: Shawn Heisey
>            Priority: Minor
>             Fix For: 4.5.1, 4.6, 5.0
>
>         Attachments: SOLR-5342.patch, SOLR-5342.patch
>
>
> ShardHandlerFactory#newInstance catches exceptions and rethrows them.  It was including
the message from the caught exception, but not including the actual exception.  This made
it difficult to figure out the root cause for an SSL initialization error.
> While fixing this, I discovered other places that are missing this as well.  Some of
them I elected not to fix, either because it's catching IOException (which normally provides
good messages), or because it was in a location that might get called frequently, which would
greatly increase logging output.



--
This message was sent by Atlassian JIRA
(v6.1#6144)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message