lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Uwe Schindler (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (LUCENE-5262) StandardDirectoryReader should decRef readers on exception, not close them
Date Mon, 07 Oct 2013 20:48:42 GMT

    [ https://issues.apache.org/jira/browse/LUCENE-5262?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13788551#comment-13788551
] 

Uwe Schindler commented on LUCENE-5262:
---------------------------------------

Oh its already committed! Please add the addSuppressed, because we should not swallow exceptions.

> StandardDirectoryReader should decRef readers on exception, not close them
> --------------------------------------------------------------------------
>
>                 Key: LUCENE-5262
>                 URL: https://issues.apache.org/jira/browse/LUCENE-5262
>             Project: Lucene - Core
>          Issue Type: Bug
>          Components: core/index
>            Reporter: Shai Erera
>            Assignee: Shai Erera
>         Attachments: LUCENE-5262.patch
>
>
> I've hit this while debugging a test, and was able to reproduce with a simple testcase.
StandardDirectoryReader.open (nrt) calls IOUtils.close() on hitting an exception from RLD.getReadOnlyClone.
But this is wrong, since if two attempts are made to obtain an NRT reader, and both of them
fail, the readers that were closed on the first time are no longer closed, since their "closed"
member is true. It should instead decRef() them. I'll upload a testcase and fix shortly.



--
This message was sent by Atlassian JIRA
(v6.1#6144)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message