lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Mark Miller (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (SOLR-4327) SolrJ code review indicates potential for leaked HttpClient connections
Date Sat, 12 Oct 2013 21:01:43 GMT

     [ https://issues.apache.org/jira/browse/SOLR-4327?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Mark Miller updated SOLR-4327:
------------------------------

    Attachment: SOLR-4327.patch

> SolrJ code review indicates potential for leaked HttpClient connections
> -----------------------------------------------------------------------
>
>                 Key: SOLR-4327
>                 URL: https://issues.apache.org/jira/browse/SOLR-4327
>             Project: Solr
>          Issue Type: Bug
>    Affects Versions: 4.0
>            Reporter: Karl Wright
>            Assignee: Mark Miller
>             Fix For: 4.5.1, 4.6, 5.0
>
>         Attachments: SOLR-4327.patch
>
>
> The SolrJ HttpSolrServer implementation does not seem to handle errors properly and seems
capable of leaking HttpClient connections.  See the request() method in org.apache.solr.client.solrj.impl.HttpSolrServer.
 The issue is that exceptions thrown from within this method do not necessarily consume the
stream when an exception is thrown.  There is a try/finally block which reads (in part):
> {code}
>     } finally {
>       if (respBody != null && processor!=null) {
>         try {
>           respBody.close();
>         } catch (Throwable t) {} // ignore
>       }
>     }
> {code}
> But, in order to always guarantee consumption of the stream, it should include:
> {code}
> method.abort();
> {code}



--
This message was sent by Atlassian JIRA
(v6.1#6144)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message