Mailing-List: contact dev-help@lucene.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@lucene.apache.org
Received-SPF: pass (athena.apache.org: domain of
 SRS0=GjxqIY=SU=basetechnology.com=jack@yourhostingaccount.com designates
 65.254.253.56 as permitted sender)
Message-ID: <45500BE2B0A548529B3BE4234E48E523@JackKrupansky>
From: "Jack Krupansky" <jack@basetechnology.com>
To: "Lucene/Solr Dev" <dev@lucene.apache.org>
Subject: copy/paste typo in solr.cloud.Overseer.getShardNames exception
Date: Sun, 8 Sep 2013 13:17:32 -0400
MIME-Version: 1.0
Content-Type: multipart/alternative;
	boundary="----=_NextPart_000_0119_01CEAC95.C69F5B40"
Importance: Normal
Sender: "Jack Krupansky" <jack@basetechnology.com>

------=_NextPart_000_0119_01CEAC95.C69F5B40
Content-Type: text/plain;
	charset="utf-8"
Content-Transfer-Encoding: quoted-printable

In org.apache.solr.cloud.Overseer.getShardNames of branch_4x, the second =
exception message is an exact copy of the first, but probably should be =
something like =E2=80=9Cshards param must specify at least one =
shard=E2=80=9D:

static void getShardNames(List<String> shardNames, String shards) {
   if(shards =3D=3Dnull)
     throw new SolrException(SolrException.ErrorCode.BAD_REQUEST, =
"shards" + " is a required param");
   for (String s : shards.split(",")) {
     if(s =3D=3Dnull || s.trim().isEmpty()) continue;
     shardNames.add(s.trim());
   }
   if(shardNames.isEmpty())
     throw new SolrException(SolrException.ErrorCode.BAD_REQUEST, =
"shards" + " is a required param");

}

-- Jack Krupansky
------=_NextPart_000_0119_01CEAC95.C69F5B40
Content-Type: text/html;
	charset="utf-8"
Content-Transfer-Encoding: quoted-printable

<HTML><HEAD></HEAD>
<BODY dir=3Dltr>
<DIV dir=3Dltr>
<DIV style=3D"FONT-SIZE: 12pt; FONT-FAMILY: 'Calibri'; COLOR: #000000">
<DIV>In org.apache.solr.cloud.Overseer.getShardNames of branch_4x, the =
second=20
exception message is an exact copy of the first, but probably should be=20
something like =E2=80=9Cshards param must specify at least one =
shard=E2=80=9D:</DIV>
<DIV>&nbsp;</DIV>
<DIV>static void getShardNames(List&lt;String&gt; shardNames, String =
shards)=20
{</DIV>
<DIV>&nbsp;&nbsp; if(shards =3D=3Dnull)</DIV>
<DIV>&nbsp;&nbsp;&nbsp;&nbsp; throw new=20
SolrException(SolrException.ErrorCode.BAD_REQUEST, "shards" + " is a =
required=20
param");</DIV>
<DIV>&nbsp;&nbsp; for (String s : shards.split(",")) {</DIV>
<DIV>&nbsp;&nbsp;&nbsp;&nbsp; if(s =3D=3Dnull || s.trim().isEmpty()) =
continue;</DIV>
<DIV>&nbsp;&nbsp;&nbsp;&nbsp; shardNames.add(s.trim());</DIV>
<DIV>&nbsp;&nbsp; }</DIV>
<DIV>&nbsp;&nbsp; if(shardNames.isEmpty())</DIV>
<DIV>&nbsp;&nbsp;&nbsp;&nbsp; throw new=20
SolrException(SolrException.ErrorCode.BAD_REQUEST, "shards" + " is a =
required=20
param");</DIV>
<DIV>&nbsp;</DIV>
<DIV>}</DIV>
<DIV><BR>-- Jack Krupansky</DIV></DIV></DIV></BODY></HTML>

------=_NextPart_000_0119_01CEAC95.C69F5B40--